From: David Miller <davem@davemloft.net>
To: tgraf@suug.ch
Cc: jeffrey.t.kirsher@intel.com, jeff@garzik.org,
netdev@vger.kernel.org, alexander.h.duyck@intel.com
Subject: Re: [PATCH 3/3] IPROUTE: generate compat messages that match nla_parse_nested_compat
Date: Thu, 28 Aug 2008 03:02:00 -0700 (PDT) [thread overview]
Message-ID: <20080828.030200.54198413.davem@davemloft.net> (raw)
In-Reply-To: <20080828095948.GY20815@postel.suug.ch>
From: Thomas Graf <tgraf@suug.ch>
Date: Thu, 28 Aug 2008 11:59:48 +0200
> * David Miller <davem@davemloft.net> 2008-08-28 02:55
> > He's doing the bogus iproute2 alternative to curing the regression
> > in PRIO and RR that was added to 2.6.26 and 2.6.25.7
> >
> > That's what this is for.
> >
> > But see my other email, we'll likely fix this in the kernel.
>
> The prio scheduler also no longer parses nested attributes, you have
> removed that piece of code when you removed RR. There is nothing to
> fix really. multiq is currently the only "real" user of
> addattr_nest_compat().
2.6.26 and 2.6.25.7 still have the prio and RR scheduler multiqueue
parts, and we broke them.
See my other reply in the other thread where this discussion
was taking place.
prev parent reply other threads:[~2008-08-28 10:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-28 1:13 [PATCH 1/3] IPROUTE: add support for multiq qdisc Jeff Kirsher
2008-08-28 1:13 ` [PATCH 2/3] IPROUTE: add support for skbedit action Jeff Kirsher
2008-08-28 1:13 ` [PATCH 3/3] IPROUTE: generate compat messages that match nla_parse_nested_compat Jeff Kirsher
2008-08-28 8:16 ` David Miller
2008-08-28 9:51 ` Thomas Graf
2008-08-28 9:55 ` David Miller
2008-08-28 9:59 ` Thomas Graf
2008-08-28 10:02 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080828.030200.54198413.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.h.duyck@intel.com \
--cc=jeff@garzik.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).