netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: Brice.Goglin@inria.fr
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [RFC] export irq_set/get_affinity() for multiqueue network drivers
Date: Thu, 28 Aug 2008 13:56:09 -0700 (PDT)	[thread overview]
Message-ID: <20080828.135609.106382483.davem@davemloft.net> (raw)
In-Reply-To: <48B708E1.4070001@inria.fr>

From: Brice Goglin <Brice.Goglin@inria.fr>
Date: Thu, 28 Aug 2008 22:21:53 +0200

> With more and more drivers using multiqueues, I think we need a nice way
> to bind MSI-X from within the drivers. I am not sure what's best, the
> attached (untested) patch would just export the existing
> irq_set_affinity() and add irq_get_affinity(). Comments?

I think we should rather have some kind of generic thing in the
IRQ layer that allows specifying the usage model of the device's
interrupts, so that the IRQ layer can choose a default affinities.

I never notice any of this complete insanity on sparc64 because
we flat spread out all of the interrupts across the machine.

What we don't want it drivers choosing IRQ affinity settings,
they have no idea about NUMA topology, what NUMA node the
PCI controller sits behind, what cpus are there, etc.  and
without that kind of knowledge you cannot possible make
affinity decisions properly.

  reply	other threads:[~2008-08-28 20:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-28 20:21 [RFC] export irq_set/get_affinity() for multiqueue network drivers Brice Goglin
2008-08-28 20:56 ` David Miller [this message]
2008-08-29  7:08   ` Brice Goglin
2008-08-29 12:50 ` Arjan van de Ven
2008-08-29 16:48   ` Andi Kleen
2008-08-29 16:52     ` Arjan van de Ven
2008-08-29 17:14     ` Rick Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080828.135609.106382483.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Brice.Goglin@inria.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).