From: Thomas Graf <tgraf@suug.ch>
To: David Miller <davem@davemloft.net>
Cc: alexander.duyck@gmail.com, shemminger@vyatta.com,
jeffrey.t.kirsher@intel.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
alexander.h.duyck@intel.com
Subject: Re: [PATCH] IPROUTE: correct nla nested message generated by netem_parse_opt
Date: Thu, 28 Aug 2008 12:18:40 +0200 [thread overview]
Message-ID: <20080828101840.GZ20815@postel.suug.ch> (raw)
In-Reply-To: <20080827.234731.77434405.davem@davemloft.net>
* David Miller <davem@davemloft.net> 2008-08-27 23:47
> It doesn't matter what "correct" compat nested attribute parsing
> is or is not. The fact is that RR and PRIO were using a certain
> format, consistently, prior to commit #6. This is what was
> codified in userspace in the iproute2 sources and worked
> correctly until #6.
So we remove nla_parsed_nested_compat() just to add it again under
a different name since netem is still going to use that piece of
code. That certainly makes sense. Fixing prio and rr in stable is
a one liner.
next prev parent reply other threads:[~2008-08-28 10:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-22 0:50 [PATCH] IPROUTE: correct nla nested message generated by netem_parse_opt Jeff Kirsher
2008-08-22 1:19 ` Stephen Hemminger
2008-08-22 2:37 ` Alexander Duyck
2008-08-22 10:44 ` David Miller
2008-08-27 14:41 ` Thomas Graf
2008-08-27 16:30 ` Duyck, Alexander H
2008-08-27 20:47 ` Thomas Graf
2008-08-27 21:10 ` Stephen Hemminger
2008-08-28 6:47 ` David Miller
2008-08-28 10:18 ` Thomas Graf [this message]
2008-08-28 10:19 ` David Miller
2008-08-28 13:03 ` [PATCH 2.6.26.y] sch_prio: Fix nla_parse_nested_compat() regression Thomas Graf
2008-09-03 0:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080828101840.GZ20815@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=akpm@linux-foundation.org \
--cc=alexander.duyck@gmail.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).