From: Ben Hutchings <bhutchings@solarflare.com>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: Jeff Garzik <jgarzik@pobox.com>, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] sky2: EEPROM read/write bug fixes
Date: Thu, 28 Aug 2008 12:13:25 +0100 [thread overview]
Message-ID: <20080828111323.GI7908@solarflare.com> (raw)
In-Reply-To: <20080827204626.4b65862f@extreme>
Stephen Hemminger wrote:
> Cleanup and harden the routines accessing the EEPROM.
> 1. Prevent spin forever waiting for the TWSI bus
> 2. Fix write eeprom to write full words rather than only 16 bits
> Luckly the vendor doesn't provide EEPROM in Linux format so it must never
> have been used.
> 3. Don't allow partial eeprom writes, not needed, not safe.
[...]
You should be able to replace the VPD access code with calls through
pci_dev->vpd->ops - though you'd need to remove some declarations from
drivers/pci/pci.h to include/linux/pci.h.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2008-08-28 11:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-28 3:46 [PATCH 1/2] sky2: EEPROM read/write bug fixes Stephen Hemminger
2008-08-28 3:48 ` [PATCH 2/2] sky2: display product info on boot Stephen Hemminger
2008-08-28 11:13 ` Ben Hutchings [this message]
2008-08-28 15:30 ` [PATCH 1/2] sky2: EEPROM read/write bug fixes Stephen Hemminger
2008-08-30 15:03 ` Stephen Hemminger
2008-08-31 20:35 ` Ben Hutchings
2008-08-31 23:24 ` Stephen Hemminger
[not found] ` <20080903155316.1a0a5698@extreme>
2008-09-03 22:57 ` [PATCH 2/3] pci: revise VPD access interface Stephen Hemminger
2008-09-03 23:00 ` [PATCH 3/3] sky2: use pci_read_vpd to read info during boot Stephen Hemminger
2008-09-04 7:36 ` Jeff Garzik
2008-09-09 4:36 ` Jesse Barnes
2008-09-03 22:57 ` [PATCH 1/3] pci: VPD access timeout increase Stephen Hemminger
2008-09-04 12:52 ` Matthew Wilcox
2008-09-04 14:19 ` Ben Hutchings
2008-09-04 16:10 ` Matthew Wilcox
2008-09-04 16:32 ` Stephen Hemminger
2008-09-04 16:07 ` [PATCH] Return value from schedule() Matthew Wilcox
2008-09-04 16:14 ` Ingo Molnar
2008-09-04 16:21 ` Matthew Wilcox
2008-09-04 17:30 ` Arjan van de Ven
2008-09-04 17:48 ` Matthew Wilcox
2008-09-04 19:05 ` Stephen Hemminger
2008-09-05 7:40 ` Peter Zijlstra
2008-09-03 14:25 ` [PATCH 1/2] sky2: EEPROM read/write bug fixes Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080828111323.GI7908@solarflare.com \
--to=bhutchings@solarflare.com \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).