From: Paul Moore <paul.moore@hp.com>
To: selinux@tycho.nsa.gov, netdev@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: [RFC PATCH v5 05/14] smack: Fix missing calls to netlbl_skbuff_err()
Date: Fri, 05 Sep 2008 19:23:44 -0400 [thread overview]
Message-ID: <20080905232344.31840.60714.stgit@flek.lan> (raw)
In-Reply-To: <20080905231853.31840.57880.stgit@flek.lan>
Smack needs to call netlbl_skbuff_err() to let NetLabel do the necessary
protocol specific error handling.
Signed-off-by: Paul Moore <paul.moore@hp.com>
---
security/smack/smack_lsm.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
index 87d7541..6e2dc0b 100644
--- a/security/smack/smack_lsm.c
+++ b/security/smack/smack_lsm.c
@@ -2179,7 +2179,10 @@ static int smack_socket_sock_rcv_skb(struct sock *sk, struct sk_buff *skb)
* This is the simplist possible security model
* for networking.
*/
- return smk_access(smack, ssp->smk_in, MAY_WRITE);
+ rc = smk_access(smack, ssp->smk_in, MAY_WRITE);
+ if (rc != 0)
+ netlbl_skbuff_err(skb, rc, 0);
+ return rc;
}
/**
next prev parent reply other threads:[~2008-09-05 23:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-05 23:23 [RFC PATCH v5 00/14] Labeled networking patches for 2.6.28 Paul Moore
2008-09-05 23:23 ` [RFC PATCH v5 01/14] netlabel: Remove unneeded in-kernel API functions Paul Moore
2008-09-05 23:23 ` [RFC PATCH v5 02/14] selinux: Better local/forward check in selinux_ip_postroute() Paul Moore
2008-09-05 23:23 ` [RFC PATCH v5 03/14] selinux: Fix a problem in security_netlbl_sid_to_secattr() Paul Moore
2008-09-05 23:23 ` [RFC PATCH v5 04/14] selinux: Fix missing calls to netlbl_skbuff_err() Paul Moore
2008-09-05 23:23 ` Paul Moore [this message]
2008-09-06 2:10 ` [RFC PATCH v5 05/14] smack: " Casey Schaufler
2008-09-05 23:23 ` [RFC PATCH v5 06/14] netlabel: Replace protocol/NetLabel linking with refrerence counts Paul Moore
2008-09-05 23:23 ` [RFC PATCH v5 07/14] netlabel: Add a generic way to create ordered linked lists of network addrs Paul Moore
2008-09-05 23:24 ` [RFC PATCH v5 08/14] netlabel: Add network address selectors to the NetLabel/LSM domain mapping Paul Moore
2008-09-05 23:24 ` [RFC PATCH v5 09/14] netlabel: Add functionality to set the security attributes of a packet Paul Moore
2008-09-05 23:24 ` [RFC PATCH v5 10/14] selinux: Set socket NetLabel based on connection endpoint Paul Moore
2008-09-05 23:24 ` [RFC PATCH v5 11/14] selinux: Cache NetLabel secattrs in the socket's security struct Paul Moore
2008-09-05 23:24 ` [RFC PATCH v5 12/14] netlabel: Changes to the NetLabel security attributes to allow LSMs to pass full contexts Paul Moore
2008-09-05 23:24 ` [RFC PATCH v5 13/14] cipso: Add support for native local labeling and fixup mapping names Paul Moore
2008-09-05 23:24 ` [RFC PATCH v5 14/14] netlabel: Add configuration support for local labeling Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080905232344.31840.60714.stgit@flek.lan \
--to=paul.moore@hp.com \
--cc=linux-security-module@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).