From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Subject: Re: [PATCH] ipvs: Use pointer to address from sync message Date: Sat, 6 Sep 2008 14:26:11 +1000 Message-ID: <20080906042610.GC21521@verge.net.au> References: <1220363755-9854-1-git-send-email-juliusv@google.com> <1220363755-9854-13-git-send-email-juliusv@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Sven Wegener , netdev@vger.kernel.org, lvs-devel@vger.kernel.org, kaber@trash.net, vbusam@google.com To: Julius Volz Return-path: Received: from kirsty.vergenet.net ([202.4.237.240]:33872 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750937AbYIFE0N (ORCPT ); Sat, 6 Sep 2008 00:26:13 -0400 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Sep 05, 2008 at 02:28:48PM +0200, Julius Volz wrote: > On Fri, Sep 5, 2008 at 1:46 PM, Sven Wegener wrote: > > We want a pointer to it, not the value casted to a pointer. > > Ouch, right! > > > Signed-off-by: Sven Wegener > > --- > > net/ipv4/ipvs/ip_vs_sync.c | 6 +++--- > > 1 files changed, 3 insertions(+), 3 deletions(-) > > > > I've been too late with having a look at these patches. I'm going to > > send follow-up patches for the issues I find. Sven, as always thanks very much for your patches. > Thanks! There are probably still lots of these easy-to-miss (but bad) > bugs in this big new bunch of code... > > > Simon, please apply onto lvs-next-2.6. > > Yes! Julius, can I take that as an Acked-by for the follwing changes? [PATCH] ipvs: Use pointer to address from sync message [PATCH] ipvs: Return negative error values from [PATCH] ipvs: Mark tcp/udp v4 and v6 debug functions static [PATCH] ipvs: Reject ipv6 link-local addresses for destinations