From: David Miller <davem@davemloft.net>
To: Santwona.Behera@Sun.COM
Cc: netdev@vger.kernel.org, Matheos.Worku@Sun.COM, agospoda@redhat.com
Subject: Re: [PATCH 1/1] niu: panic on reset
Date: Mon, 08 Sep 2008 13:20:31 -0700 (PDT) [thread overview]
Message-ID: <20080908.132031.65821182.davem@davemloft.net> (raw)
In-Reply-To: <48C07564.3060306@Sun.COM>
From: Santwona.Behera@Sun.COM
Date: Thu, 04 Sep 2008 16:55:16 -0700
[ Please learn how to hit the return key every 80 characters or so,
long lines are very difficult to read on text-only email clients
like the one I use. Expecting auto-formatting and other beautifications
in email readers amongst kernel developers is a very bad idea. ]
> The reset_task function in the niu driver does not reset the
> hardware fully. The buffer addresses and pointers are not being
> reset/updated in the hardware and that leads to panic on reset.
>
> Signed-off-by: santwona.behera@sun.com <santwona.behera@sun.com>
This is way overkill just to fix this bug and it adds a new failure
mode for the driver which is a seriously negative aspect to this fix.
Instead, simply write a function which reloads the buffers addresses
properly instead of calling the functions to free and reallocate all
of these dynamic datastructures just to get those side effects.
next prev parent reply other threads:[~2008-09-08 20:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-04 23:55 [PATCH 1/1] niu: panic on reset Santwona.Behera
2008-09-08 20:20 ` David Miller [this message]
2008-09-10 17:01 ` Matheos Worku
2008-09-10 20:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080908.132031.65821182.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Matheos.Worku@Sun.COM \
--cc=Santwona.Behera@Sun.COM \
--cc=agospoda@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).