Re: Bluetooth fixes for 2.6.27

[David Miller <davem@davemloft.net>]

From: Marcel Holtmann <marcel@holtmann.org>
Date: Mon, 08 Sep 2008 23:53:57 +0200

> The first patch is a clear regression that got introduced with
> 2.6.27-rc1 when adding Simple Pairing support. I forgot to decrease the
> reference count on an incoming ACL link. This patch actually makes the
> code simpler.

This is OK.

> The second patch fixes the authentication requirements. We do have to
> separate between service discovery and actual profile channels. This is
> a clear requirement of the Bluetooth Security Mode 4 introduced with the
> addition of the Simple Pairing support. Not fixing this will result in
> broken behavior when doing service discovery with Simple Pairing enabled
> devices.

What regression reported by a user is fixed by this?

This does not look like it is appropriate outside of the merge window.

> The third patch rejects insecure incoming connections. This is a clear
> security issues since we can't rely on the initiator doing the right
> thing and establishing an encrypted link. Malicious devices would just
> skip that step and in that case we have to reject connection attempt
> without going into the connection phase at all.

This is OK.