From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: xfrm_state locking regression... Date: Tue, 09 Sep 2008 20:38:08 -0700 (PDT) Message-ID: <20080909.203808.112347106.davem@davemloft.net> References: <20080910031559.GA27430@gondor.apana.org.au> <20080909.202215.197131148.davem@davemloft.net> <20080910032304.GA28580@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: timo.teras@iki.fi, netdev@vger.kernel.org To: herbert@gondor.apana.org.au Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:41346 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751949AbYIJDiP (ORCPT ); Tue, 9 Sep 2008 23:38:15 -0400 In-Reply-To: <20080910032304.GA28580@gondor.apana.org.au> Sender: netdev-owner@vger.kernel.org List-ID: From: Herbert Xu Date: Wed, 10 Sep 2008 13:23:04 +1000 > On Tue, Sep 09, 2008 at 08:22:15PM -0700, David Miller wrote: > > > > > What could be done though is to remove x->all and restore the > > > original walking by hashing. This would eliminate a list node > > > from xfrm_state, and would also restore the original dump ordering. > > > > Yes I remember you mentioning that. > > > > If you're too busy I can try to spin this idea into a patch. > > That would be very much appreciated. Thanks Dave! No problem. It might be a little bit of a chore because this new walker design is intimately tied to the af_key non-atomic dump changes.