Re: [RFC] Control Group Classifier

[Thomas Graf <tgraf@suug.ch>]

* Ranjit Manomohan <ranjitm@google.com> 2008-09-08 14:28
> Wouldn't this cause a lot of packets (like acks)  to be incorrectly
> classifed to the current tasks cgroup although it may not have
> anything to do with them? That is the reason I chose to put the
> classid into the socket at creation time.

In its current form, it does not work if the packet is rescheduled
or not sent in the context of a process. Such packets simply end
up not being classified at all. In the most common case, the packet
is not queued before it hits the qdisc so this takes away a lot of
complexity and is very fast but should still be sufficient.

Alternatively I also thought about doing a socket lookup in the
classifier (if !skb->sk) and store the classid in the socket. This
would add more flexibility and work for ingress traffic whitout
adding pollution to the sk_buff. It adds a heavy operation to the
classification process though as it would probably require a lock.