From: David Miller <davem@davemloft.net>
To: Matheos.Worku@Sun.COM
Cc: Santwona.Behera@Sun.COM, netdev@vger.kernel.org
Subject: Re: [PATCH 1/1] niu: panic on reset
Date: Wed, 10 Sep 2008 13:28:08 -0700 (PDT) [thread overview]
Message-ID: <20080910.132808.242997035.davem@davemloft.net> (raw)
In-Reply-To: <48C7FD76.2000206@sun.com>
From: Matheos Worku <Matheos.Worku@Sun.COM>
Date: Wed, 10 Sep 2008 10:01:42 -0700
> Instead of creating a new function, Santwona was borrowing an existing
> logic from niu_change_mtu function. Rather than introducing a new
> function and possibly a new failure mode, we were trying to re-use existing
> logic, reducing the probability of a new bug.
But in essence the patch does add a new failure mode. It now can fail
if a memory allocation cannot succeed at the current point in time.
That was not true previously, and if you just fix up the buffer pointers
or whatever state to be reset, you won't have this possible failure mode
either.
We should fix this correctly.
prev parent reply other threads:[~2008-09-10 20:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-04 23:55 [PATCH 1/1] niu: panic on reset Santwona.Behera
2008-09-08 20:20 ` David Miller
2008-09-10 17:01 ` Matheos Worku
2008-09-10 20:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080910.132808.242997035.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Matheos.Worku@Sun.COM \
--cc=Santwona.Behera@Sun.COM \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).