From: David Miller <davem@davemloft.net>
To: ranjitm@google.com
Cc: tgraf@suug.ch, akpm@linux-foundation.org, kaber@trash.net,
lizf@cn.fujitsu.com, menage@google.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] Traffic control cgroups subsystem
Date: Wed, 10 Sep 2008 16:00:26 -0700 (PDT) [thread overview]
Message-ID: <20080910.160026.31554352.davem@davemloft.net> (raw)
In-Reply-To: <166fe7950809101556q61cb7e30m2d5e758304618f61@mail.gmail.com>
From: "Ranjit Manomohan" <ranjitm@google.com>
Date: Wed, 10 Sep 2008 15:56:55 -0700
> That is correct for ingress, for egress the sk is already available in
> the skb so should be fine.
That is not something you can rely upon, even for egress, %100 of the time.
Some forms of reallocation and mangling might decide to orphan the SKB
and thus drop the skb->sk reference before you see the packet. And they
are absolutely free to do this.
Just grep for skb_orphan().
Therefore, it is absolutely something you should not rely upon for
correct operation.
Like I said from the beginning, Thomas's approach is the superior one.
next prev parent reply other threads:[~2008-09-10 23:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-10 17:42 [PATCH 1/2] Traffic control cgroups subsystem Ranjit Manomohan
2008-09-10 22:01 ` Thomas Graf
2008-09-10 22:56 ` Ranjit Manomohan
2008-09-10 23:00 ` David Miller [this message]
2008-09-10 23:14 ` Ranjit Manomohan
2008-09-10 23:04 ` Paul Menage
2008-09-10 23:24 ` Thomas Graf
2008-09-10 23:31 ` Paul Menage
2008-09-10 23:45 ` Thomas Graf
2008-09-10 23:51 ` Paul Menage
2008-09-11 0:07 ` Thomas Graf
2008-09-11 0:09 ` Paul Menage
2008-09-10 23:53 ` Paul Menage
-- strict thread matches above, loose matches on Subject: below --
2008-08-22 0:55 Ranjit Manomohan
2008-08-22 2:11 ` Li Zefan
2008-07-24 23:35 Ranjit Manomohan
2008-07-18 21:28 Ranjit Manomohan
2008-07-21 9:26 ` Li Zefan
2008-07-21 14:04 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080910.160026.31554352.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
--cc=netdev@vger.kernel.org \
--cc=ranjitm@google.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).