From: Thomas Graf <tgraf@suug.ch>
To: Paul Menage <menage@google.com>
Cc: Ranjit Manomohan <ranjitm@google.com>,
davem@davemloft.net, akpm@linux-foundation.org, kaber@trash.net,
lizf@cn.fujitsu.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] Traffic control cgroups subsystem
Date: Thu, 11 Sep 2008 01:45:23 +0200 [thread overview]
Message-ID: <20080910234523.GK20815@postel.suug.ch> (raw)
In-Reply-To: <6599ad830809101631q51371f75w2ab9f73ef2414f90@mail.gmail.com>
* Paul Menage <menage@google.com> 2008-09-10 16:31
> Yes, for this particular case it doesn't work. But isn't it much more
> likely that the admin/user will know that web-browsers tend to trigger
> bulk data transfers and configure the system so that the web browser
> always starts in its own cgroup, rather than trying to jump on it
> after the fact?
That's argueable I guess. Likely or not, it doesn't make sense to
add such restrictions if not required, especially not when it is
trivial to just look at the cgroup of the task directly.
If the ingress case is of such importance, I'd propose to lookup
the classid via skb -> socket -> task -> classid.
Anyways, I think we've listed all the pros and cons of either approach.
next prev parent reply other threads:[~2008-09-10 23:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-10 17:42 [PATCH 1/2] Traffic control cgroups subsystem Ranjit Manomohan
2008-09-10 22:01 ` Thomas Graf
2008-09-10 22:56 ` Ranjit Manomohan
2008-09-10 23:00 ` David Miller
2008-09-10 23:14 ` Ranjit Manomohan
2008-09-10 23:04 ` Paul Menage
2008-09-10 23:24 ` Thomas Graf
2008-09-10 23:31 ` Paul Menage
2008-09-10 23:45 ` Thomas Graf [this message]
2008-09-10 23:51 ` Paul Menage
2008-09-11 0:07 ` Thomas Graf
2008-09-11 0:09 ` Paul Menage
2008-09-10 23:53 ` Paul Menage
-- strict thread matches above, loose matches on Subject: below --
2008-08-22 0:55 Ranjit Manomohan
2008-08-22 2:11 ` Li Zefan
2008-07-24 23:35 Ranjit Manomohan
2008-07-18 21:28 Ranjit Manomohan
2008-07-21 9:26 ` Li Zefan
2008-07-21 14:04 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080910234523.GK20815@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
--cc=netdev@vger.kernel.org \
--cc=ranjitm@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).