netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: mcarlson@broadcom.com
Cc: netdev@vger.kernel.org, mchan@broadcom.com, andy@greyhouse.net
Subject: Re: [PATCH 1/1] tg3: Avoid Send BD corruption
Date: Thu, 11 Sep 2008 14:51:54 -0700 (PDT)	[thread overview]
Message-ID: <20080911.145154.112457696.davem@davemloft.net> (raw)
In-Reply-To: <20080911165913.GA27725@xw6200.broadcom.net>

From: "Matt Carlson" <mcarlson@broadcom.com>
Date: Thu, 11 Sep 2008 09:59:13 -0700

> On Wed, Sep 10, 2008 at 10:46:18PM -0700, David Miller wrote:
> > Are users really hitting this or was this discovered by your own
> > internal testing and verification?
> 
> The bug was discovered by our own internal testing, but this bug is
> severe enough to warrant submission to the net-2.6 kernel.  I'll be
> sending a patch to stable as well.
> 
> These chips are relatively new so there isn't a whole lot of opportunity
> for users to experience the problem yet.  As the chips are distributed,
> the likelyhood that users will encounter this problem is pretty high.

That doesn't matter.  That isn't the criteria for inclusion outside of
the merge window, or into -stable.

You should read postings such as the following one and the other ones
in it's thread so that you can become familiar with the criteria:

	http://marc.info/?l=linux-netdev&m=122048757705315&w=2

And by those descriptions, this patch is not appropriate and I'm
therefore not going to try and submit it for 2.6.27 and risk getting
my head chopped off by Linus again in public.





  reply	other threads:[~2008-09-11 21:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-11  5:12 [PATCH 1/1] tg3: Avoid Send BD corruption Matt Carlson
2008-09-11  5:46 ` David Miller
2008-09-11 16:59   ` Matt Carlson
2008-09-11 21:51     ` David Miller [this message]
2008-09-11 22:55       ` Michael Chan
2008-09-11 23:01         ` David Miller
2008-09-11 23:19           ` Michael Chan
2008-09-11 23:30             ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080911.145154.112457696.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=andy@greyhouse.net \
    --cc=mcarlson@broadcom.com \
    --cc=mchan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).