From: "Matt Carlson" <mcarlson@broadcom.com>
To: "David Miller" <davem@davemloft.net>
Cc: "Matthew Carlson" <mcarlson@broadcom.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Michael Chan" <mchan@broadcom.com>,
"andy@greyhouse.net" <andy@greyhouse.net>
Subject: Re: [PATCH 1/1] tg3: Avoid Send BD corruption
Date: Thu, 11 Sep 2008 09:59:13 -0700 [thread overview]
Message-ID: <20080911165913.GA27725@xw6200.broadcom.net> (raw)
In-Reply-To: <20080910.224618.113269063.davem@davemloft.net>
On Wed, Sep 10, 2008 at 10:46:18PM -0700, David Miller wrote:
> From: "Matt Carlson" <mcarlson@broadcom.com>
> Date: Wed, 10 Sep 2008 22:12:45 -0700
>
> > On 5761 and 5784 ASIC revision chips, there is a chance that send BDs
> > can be corrupted when CLKREQ is enabled. This patch turns CLKREQ off
> > while the driver is in control of the device.
> >
> > This patch also bumps up the version to 3.95.
> >
> > Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
> > Signed-off-by: Michael Chan <mchan@broadcom.com>
>
> Are users really hitting this or was this discovered by your own
> internal testing and verification?
The bug was discovered by our own internal testing, but this bug is
severe enough to warrant submission to the net-2.6 kernel. I'll be
sending a patch to stable as well.
These chips are relatively new so there isn't a whole lot of opportunity
for users to experience the problem yet. As the chips are distributed,
the likelyhood that users will encounter this problem is pretty high.
next prev parent reply other threads:[~2008-09-11 16:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-11 5:12 [PATCH 1/1] tg3: Avoid Send BD corruption Matt Carlson
2008-09-11 5:46 ` David Miller
2008-09-11 16:59 ` Matt Carlson [this message]
2008-09-11 21:51 ` David Miller
2008-09-11 22:55 ` Michael Chan
2008-09-11 23:01 ` David Miller
2008-09-11 23:19 ` Michael Chan
2008-09-11 23:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080911165913.GA27725@xw6200.broadcom.net \
--to=mcarlson@broadcom.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).