From: Stephen Hemminger <shemminger@vyatta.com>
To: David Miller <davem@davemloft.net>
Cc: kaber@trash.net, netdev@vger.kernel.org
Subject: Re: [PATCH] retain ABI definitions for obsolete multi-queue packet schedulers
Date: Fri, 12 Sep 2008 15:58:30 -0700 [thread overview]
Message-ID: <20080912155830.5ff50c59@extreme> (raw)
In-Reply-To: <20080912.153033.157394228.davem@davemloft.net>
On Fri, 12 Sep 2008 15:30:33 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
> From: Stephen Hemminger <shemminger@vyatta.com>
> Date: Fri, 12 Sep 2008 12:25:48 -0700
>
> > On Fri, 12 Sep 2008 10:00:11 -0700
> > Stephen Hemminger <shemminger@vyatta.com> wrote:
> >
> > > Even though the sch_rr qdisc is now gone in 2.6.27, the kernel
> > > definitions for the attributes need to be maintained because applications
> > > like iproute need to be compatible with older kernels and use santized
> > > kernel headers.
> ...
> > This should be applied for 2.6.27 since it is a build regression.
>
> You use a local copy of this header file in iproute2, you don't even
> use the kernel header itself. It's the worst possible example and
> excuse for this change.
>
> Nobody references this header directly for these definitions.
> The one and only use is using a local copy.
>
> iproute2 is the only thing even remotely referencing this stuff.
>
> So there is no breakage. The only breakage is if you, Stephen, decide
> to copy the kernel header into iproute2 as-is, and that is your
> choice. :-)
Every release I copy the sanitized kernel headers resulting
from 'make headers_install'. That is how they have been maintained and
up until now it worked. The sch_rr configuration portion was referencing
this. The point of the sanitized headers was to avoid this nonsense.
next prev parent reply other threads:[~2008-09-12 22:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-12 17:00 [PATCH] retain ABI definitions for obsolete multi-queue packet schedulers Stephen Hemminger
2008-09-12 19:25 ` Stephen Hemminger
2008-09-12 22:30 ` David Miller
2008-09-12 22:58 ` Stephen Hemminger [this message]
2008-09-12 23:01 ` David Miller
2008-09-12 23:03 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080912155830.5ff50c59@extreme \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).