* [PATCH] retain ABI definitions for obsolete multi-queue packet schedulers
@ 2008-09-12 17:00 Stephen Hemminger
2008-09-12 19:25 ` Stephen Hemminger
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Hemminger @ 2008-09-12 17:00 UTC (permalink / raw)
To: David Miller, Patrick McHardy, PJ Waskiewicz; +Cc: netdev
Even though the sch_rr qdisc is now gone in 2.6.27, the kernel
definitions for the attributes need to be maintained because applications
like iproute need to be compatible with older kernels and use santized
kernel headers.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/include/linux/pkt_sched.h 2008-09-12 09:56:39.000000000 -0700
+++ b/include/linux/pkt_sched.h 2008-09-12 09:57:49.000000000 -0700
@@ -123,6 +123,16 @@ struct tc_prio_qopt
__u8 priomap[TC_PRIO_MAX+1]; /* Map: logical priority -> PRIO band */
};
+/* Obsolete option from original multiqueue */
+enum
+{
+ TCA_PRIO_UNSPEC,
+ TCA_PRIO_MQ,
+ __TCA_PRIO_MAX
+};
+
+#define TCA_PRIO_MAX (__TCA_PRIO_MAX - 1)
+
/* TBF section */
struct tc_tbf_qopt
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] retain ABI definitions for obsolete multi-queue packet schedulers
2008-09-12 17:00 [PATCH] retain ABI definitions for obsolete multi-queue packet schedulers Stephen Hemminger
@ 2008-09-12 19:25 ` Stephen Hemminger
2008-09-12 22:30 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Hemminger @ 2008-09-12 19:25 UTC (permalink / raw)
Cc: Patrick McHardy, netdev
On Fri, 12 Sep 2008 10:00:11 -0700
Stephen Hemminger <shemminger@vyatta.com> wrote:
> Even though the sch_rr qdisc is now gone in 2.6.27, the kernel
> definitions for the attributes need to be maintained because applications
> like iproute need to be compatible with older kernels and use santized
> kernel headers.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>
> --- a/include/linux/pkt_sched.h 2008-09-12 09:56:39.000000000 -0700
> +++ b/include/linux/pkt_sched.h 2008-09-12 09:57:49.000000000 -0700
> @@ -123,6 +123,16 @@ struct tc_prio_qopt
> __u8 priomap[TC_PRIO_MAX+1]; /* Map: logical priority -> PRIO band */
> };
>
> +/* Obsolete option from original multiqueue */
> +enum
> +{
> + TCA_PRIO_UNSPEC,
> + TCA_PRIO_MQ,
> + __TCA_PRIO_MAX
> +};
> +
> +#define TCA_PRIO_MAX (__TCA_PRIO_MAX - 1)
> +
> /* TBF section */
>
> struct tc_tbf_qopt
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
This should be applied for 2.6.27 since it is a build regression.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] retain ABI definitions for obsolete multi-queue packet schedulers
2008-09-12 19:25 ` Stephen Hemminger
@ 2008-09-12 22:30 ` David Miller
2008-09-12 22:58 ` Stephen Hemminger
0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2008-09-12 22:30 UTC (permalink / raw)
To: shemminger; +Cc: kaber, netdev
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Fri, 12 Sep 2008 12:25:48 -0700
> On Fri, 12 Sep 2008 10:00:11 -0700
> Stephen Hemminger <shemminger@vyatta.com> wrote:
>
> > Even though the sch_rr qdisc is now gone in 2.6.27, the kernel
> > definitions for the attributes need to be maintained because applications
> > like iproute need to be compatible with older kernels and use santized
> > kernel headers.
...
> This should be applied for 2.6.27 since it is a build regression.
You use a local copy of this header file in iproute2, you don't even
use the kernel header itself. It's the worst possible example and
excuse for this change.
Nobody references this header directly for these definitions.
The one and only use is using a local copy.
iproute2 is the only thing even remotely referencing this stuff.
So there is no breakage. The only breakage is if you, Stephen, decide
to copy the kernel header into iproute2 as-is, and that is your
choice. :-)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] retain ABI definitions for obsolete multi-queue packet schedulers
2008-09-12 22:30 ` David Miller
@ 2008-09-12 22:58 ` Stephen Hemminger
2008-09-12 23:01 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Hemminger @ 2008-09-12 22:58 UTC (permalink / raw)
To: David Miller; +Cc: kaber, netdev
On Fri, 12 Sep 2008 15:30:33 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
> From: Stephen Hemminger <shemminger@vyatta.com>
> Date: Fri, 12 Sep 2008 12:25:48 -0700
>
> > On Fri, 12 Sep 2008 10:00:11 -0700
> > Stephen Hemminger <shemminger@vyatta.com> wrote:
> >
> > > Even though the sch_rr qdisc is now gone in 2.6.27, the kernel
> > > definitions for the attributes need to be maintained because applications
> > > like iproute need to be compatible with older kernels and use santized
> > > kernel headers.
> ...
> > This should be applied for 2.6.27 since it is a build regression.
>
> You use a local copy of this header file in iproute2, you don't even
> use the kernel header itself. It's the worst possible example and
> excuse for this change.
>
> Nobody references this header directly for these definitions.
> The one and only use is using a local copy.
>
> iproute2 is the only thing even remotely referencing this stuff.
>
> So there is no breakage. The only breakage is if you, Stephen, decide
> to copy the kernel header into iproute2 as-is, and that is your
> choice. :-)
Every release I copy the sanitized kernel headers resulting
from 'make headers_install'. That is how they have been maintained and
up until now it worked. The sch_rr configuration portion was referencing
this. The point of the sanitized headers was to avoid this nonsense.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] retain ABI definitions for obsolete multi-queue packet schedulers
2008-09-12 22:58 ` Stephen Hemminger
@ 2008-09-12 23:01 ` David Miller
2008-09-12 23:03 ` Stephen Hemminger
0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2008-09-12 23:01 UTC (permalink / raw)
To: shemminger; +Cc: kaber, netdev
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Fri, 12 Sep 2008 15:58:30 -0700
> On Fri, 12 Sep 2008 15:30:33 -0700 (PDT)
> David Miller <davem@davemloft.net> wrote:
>
> > From: Stephen Hemminger <shemminger@vyatta.com>
> > Date: Fri, 12 Sep 2008 12:25:48 -0700
> >
> > > On Fri, 12 Sep 2008 10:00:11 -0700
> > > Stephen Hemminger <shemminger@vyatta.com> wrote:
> > >
> > > > Even though the sch_rr qdisc is now gone in 2.6.27, the kernel
> > > > definitions for the attributes need to be maintained because applications
> > > > like iproute need to be compatible with older kernels and use santized
> > > > kernel headers.
> > ...
> > > This should be applied for 2.6.27 since it is a build regression.
> >
> > You use a local copy of this header file in iproute2, you don't even
> > use the kernel header itself. It's the worst possible example and
> > excuse for this change.
> >
> > Nobody references this header directly for these definitions.
> > The one and only use is using a local copy.
> >
> > iproute2 is the only thing even remotely referencing this stuff.
> >
> > So there is no breakage. The only breakage is if you, Stephen, decide
> > to copy the kernel header into iproute2 as-is, and that is your
> > choice. :-)
>
> Every release I copy the sanitized kernel headers resulting
> from 'make headers_install'. That is how they have been maintained and
> up until now it worked. The sch_rr configuration portion was referencing
> this. The point of the sanitized headers was to avoid this nonsense.
But here is the flip side, we actually don't want new applications
referencing those things, since no kernel from now and into the
future will ever support those knobs again. They will always fail.
Therefore, it makes sense to put the definitions into the one existing
tool that used it. You can even put those defines directly into the
sch_rr iproute2 code, and then your sanitized header bits will
continue to work transparently.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] retain ABI definitions for obsolete multi-queue packet schedulers
2008-09-12 23:01 ` David Miller
@ 2008-09-12 23:03 ` Stephen Hemminger
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Hemminger @ 2008-09-12 23:03 UTC (permalink / raw)
To: David Miller; +Cc: kaber, netdev
On Fri, 12 Sep 2008 16:01:54 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
> From: Stephen Hemminger <shemminger@vyatta.com>
> Date: Fri, 12 Sep 2008 15:58:30 -0700
>
> > On Fri, 12 Sep 2008 15:30:33 -0700 (PDT)
> > David Miller <davem@davemloft.net> wrote:
> >
> > > From: Stephen Hemminger <shemminger@vyatta.com>
> > > Date: Fri, 12 Sep 2008 12:25:48 -0700
> > >
> > > > On Fri, 12 Sep 2008 10:00:11 -0700
> > > > Stephen Hemminger <shemminger@vyatta.com> wrote:
> > > >
> > > > > Even though the sch_rr qdisc is now gone in 2.6.27, the kernel
> > > > > definitions for the attributes need to be maintained because applications
> > > > > like iproute need to be compatible with older kernels and use santized
> > > > > kernel headers.
> > > ...
> > > > This should be applied for 2.6.27 since it is a build regression.
> > >
> > > You use a local copy of this header file in iproute2, you don't even
> > > use the kernel header itself. It's the worst possible example and
> > > excuse for this change.
> > >
> > > Nobody references this header directly for these definitions.
> > > The one and only use is using a local copy.
> > >
> > > iproute2 is the only thing even remotely referencing this stuff.
> > >
> > > So there is no breakage. The only breakage is if you, Stephen, decide
> > > to copy the kernel header into iproute2 as-is, and that is your
> > > choice. :-)
> >
> > Every release I copy the sanitized kernel headers resulting
> > from 'make headers_install'. That is how they have been maintained and
> > up until now it worked. The sch_rr configuration portion was referencing
> > this. The point of the sanitized headers was to avoid this nonsense.
>
> But here is the flip side, we actually don't want new applications
> referencing those things, since no kernel from now and into the
> future will ever support those knobs again. They will always fail.
>
> Therefore, it makes sense to put the definitions into the one existing
> tool that used it. You can even put those defines directly into the
> sch_rr iproute2 code, and then your sanitized header bits will
> continue to work transparently.
>
More likely, I'll just drop sch_rr support from the utilities.
They were just a flash in the pan for a brief period.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-09-12 23:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-12 17:00 [PATCH] retain ABI definitions for obsolete multi-queue packet schedulers Stephen Hemminger
2008-09-12 19:25 ` Stephen Hemminger
2008-09-12 22:30 ` David Miller
2008-09-12 22:58 ` Stephen Hemminger
2008-09-12 23:01 ` David Miller
2008-09-12 23:03 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).