From: Grant Grundler <grundler@parisc-linux.org>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: netdev@vger.kernel.org, grundler@parisc-linux.org,
kyle@parisc-linux.org, tbm@cyrius.com
Subject: Re: [PATCH] Fix dead 21041 ethernet after ifconfig down
Date: Sat, 13 Sep 2008 12:05:09 -0600 [thread overview]
Message-ID: <20080913180509.GA8392@colo.lackof.org> (raw)
In-Reply-To: <20080912211919.1C36FC2AFD@solo.franken.de>
On Fri, Sep 12, 2008 at 11:19:19PM +0200, Thomas Bogendoerfer wrote:
> The de2104x did a pci_disable_device() in it's close function, but
> the open function never does a pci_enable_device() and assumes that
> the device is already enabled. Considering that downing the interface
> is just a temporary thing the pci_disable_device() isn't a pretty good
> idea and removing it from the close function just fixes the bug.
Thomas,
Thanks for the patch!
The de2104 driver is calling pci_enable_device() in it's .probe routine
and calls pci_disable_device in it's .remove function.
It never occurred to me a NIC driver would call either pci function
from someplace else as well.
> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Acked-by: Grant Grundler <grundler@parisc-linux.org>
> ---
>
> drivers/net/tulip/de2104x.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/tulip/de2104x.c b/drivers/net/tulip/de2104x.c
> index 9281d06..f54c450 100644
> --- a/drivers/net/tulip/de2104x.c
> +++ b/drivers/net/tulip/de2104x.c
> @@ -1418,7 +1418,6 @@ static int de_close (struct net_device *dev)
>
> de_free_rings(de);
> de_adapter_sleep(de);
> - pci_disable_device(de->pdev);
> return 0;
> }
>
next prev parent reply other threads:[~2008-09-13 18:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-12 21:19 [PATCH] Fix dead 21041 ethernet after ifconfig down Thomas Bogendoerfer
2008-09-13 18:05 ` Grant Grundler [this message]
2008-09-13 19:06 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080913180509.GA8392@colo.lackof.org \
--to=grundler@parisc-linux.org \
--cc=kyle@parisc-linux.org \
--cc=netdev@vger.kernel.org \
--cc=tbm@cyrius.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).