From: Jeff Garzik <jeff@garzik.org>
To: David Miller <davem@davemloft.net>
Cc: jacliburn@bellsouth.net, adobriyan@gmail.com, csnook@redhat.com,
netdev@vger.kernel.org
Subject: Re: atl1: WARNING at net/sched/sch_generic.c:221
Date: Sun, 14 Sep 2008 23:14:14 -0400 [thread overview]
Message-ID: <20080915031414.GA3028@havoc.gtf.org> (raw)
In-Reply-To: <20080914.165655.193720725.davem@davemloft.net>
On Sun, Sep 14, 2008 at 04:56:55PM -0700, David Miller wrote:
> From: Jay Cliburn <jacliburn@bellsouth.net>
> Date: Sun, 14 Sep 2008 14:26:54 -0500
>
> > Should a netdev driver be coded such that a watchdog transmit timeout
> > never occurs?
> >
> > [ 2086.049998] NETDEV WATCHDOG: eth0 (atl1): transmit timed out
> >
> > Or is a watchdog timeout an expected occurrence if a cable is
> > unplugged/plugged?
>
> If the cable is unplugged, netif_carrier_off() will be (or should
> be) invoked by the driver, and that cancels the watchdog timer.
100% correct :)
As Stephen noted, a transmit timeout is an unhandled condition plain and
simple -- either unhandled by the driver or unhandled by the hardware.
Jeff
next prev parent reply other threads:[~2008-09-15 3:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 11:58 atl1: WARNING at net/sched/sch_generic.c:221 adobriyan
2008-08-21 11:59 ` David Miller
2008-08-21 12:04 ` adobriyan
2008-08-21 12:08 ` David Miller
2008-09-14 19:26 ` Jay Cliburn
2008-09-14 19:58 ` Stephen Hemminger
2008-09-14 23:56 ` David Miller
2008-09-15 0:11 ` Jay Cliburn
2008-09-15 3:14 ` Jeff Garzik [this message]
2008-08-22 2:00 ` Jay Cliburn
2008-08-22 21:50 ` Jay Cliburn
2008-09-14 23:17 ` Jay Cliburn
2008-09-15 22:45 ` Alexey Dobriyan
2008-09-16 1:44 ` Jay Cliburn
2008-09-17 7:44 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080915031414.GA3028@havoc.gtf.org \
--to=jeff@garzik.org \
--cc=adobriyan@gmail.com \
--cc=csnook@redhat.com \
--cc=davem@davemloft.net \
--cc=jacliburn@bellsouth.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).