From: David Miller <davem@davemloft.net>
To: vladislav.yasevich@hp.com
Cc: linux-sctp@vger.kernel.org,
lksctp-developers@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] sctp: Fix oops when INIT-ACK indicates that peer doesn't support AUTH
Date: Thu, 18 Sep 2008 16:29:48 -0700 (PDT) [thread overview]
Message-ID: <20080918.162948.150019388.davem@davemloft.net> (raw)
In-Reply-To: <1221773464-28845-2-git-send-email-vladislav.yasevich@hp.com>
From: Vlad Yasevich <vladislav.yasevich@hp.com>
Date: Thu, 18 Sep 2008 17:31:04 -0400
> If INIT-ACK is received with SupportedExtensions parameter which
> indicates that the peer does not support AUTH, the packet will be
> silently ignore, and sctp_process_init() do cleanup all of the
> transports in the association.
> When T1-Init timer is expires, OOPS happen while we try to choose
> a different init transport.
>
> The solution is to only clean up the non-active transports, i.e
> the ones that the peer added. However, that introduces a problem
> with sctp_connectx(), because we don't mark the proper state for
> the transports provided by the user. So, we'll simply mark
> user-provided transports as ACTIVE. That will allow INIT
> retransmissions to work properly in the sctp_connectx() context
> and prevent the crash.
>
> Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Applied, thanks.
next prev parent reply other threads:[~2008-09-18 23:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-18 21:31 [PATCH 1/2] sctp: do not enable peer features if we can't do them Vlad Yasevich
2008-09-18 21:31 ` [PATCH 2/2] sctp: Fix oops when INIT-ACK indicates that peer doesn't support AUTH Vlad Yasevich
2008-09-18 23:29 ` David Miller [this message]
2008-09-18 23:01 ` [Lksctp-developers] [PATCH 1/2] sctp: do not enable peer features if we can't do them Vlad Yasevich
2008-09-18 23:18 ` David Miller
2008-09-18 23:29 ` David Miller
2008-09-19 3:01 ` Vlad Yasevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080918.162948.150019388.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=lksctp-developers@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=vladislav.yasevich@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).