From: David Miller <davem@davemloft.net>
To: mathieu.lacage@sophia.inria.fr
Cc: netdev@vger.kernel.org
Subject: Re: clarify code intent
Date: Thu, 18 Sep 2008 16:36:33 -0700 (PDT) [thread overview]
Message-ID: <20080918.163633.223533656.davem@davemloft.net> (raw)
In-Reply-To: <1221757668.23007.12.camel@ns-test>
From: Mathieu Lacage <mathieu.lacage@sophia.inria.fr>
Date: Thu, 18 Sep 2008 10:07:48 -0700
> The attached patch hopefully clarifies the intent of the unix_bind
> function in net/unix/af_unix.c.
I've rejected this patch over and over in the past, and nothing
has happened to change my mind since then.
----------------------------------------
Subject: Re: [PATCH,TRIVIAL] AF_UNIX, accept() and addrlen
From: David Miller <davem@davemloft.net>
To: samuel.thibault@ens-lyon.org
Cc: mtk.manpages@gmail.com, mtk.manpages@googlemail.com,
andi@firstfloor.org, linux-kernel@vger.kernel.org
Date: Sat, 26 Apr 2008 22:54:32 -0700 (PDT)
X-Mailer: Mew version 5.2 on Emacs 22.1 / Mule 5.0 (SAKAKI)
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
Date: Sat, 26 Apr 2008 02:44:45 +0100
> AF_UNIX: make unix_getname use sizeof(sunaddr->sun_family) instead of
> sizeof(short).
>
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
This is just syntactic masterbation, sa_family_t is typedef'd
"unsigned short".
No system on planet earth providing the BSD sockets API uses
anything other than uint16_t or unsigned short for this.
Sorry, I'm not applying this.
next prev parent reply other threads:[~2008-09-18 23:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-18 17:07 clarify code intent Mathieu Lacage
2008-09-18 23:36 ` David Miller [this message]
2008-09-18 23:53 ` Mathieu Lacage
2008-09-18 23:59 ` David Miller
2008-09-23 0:29 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080918.163633.223533656.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=mathieu.lacage@sophia.inria.fr \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).