From: David Miller <davem@davemloft.net>
To: benli@broadcom.com
Cc: jeff@garzik.org, netdev@vger.kernel.org
Subject: Re: [UPDATED][NET-NEXT PATCH 4/4] bnx2: Remove timer_interval field from the bnx2 structure
Date: Thu, 18 Sep 2008 16:40:58 -0700 (PDT) [thread overview]
Message-ID: <20080918.164058.43305872.davem@davemloft.net> (raw)
In-Reply-To: <1221757033-4874-5-git-send-email-benli@broadcom.com>
From: "Benjamin Li" <benli@broadcom.com>
Date: Thu, 18 Sep 2008 09:57:13 -0700
> The timer_interval field is only assigned once, and never reassigned.
> We can safely replace all instances of the timer_interval with a
> constant value.
>
> Signed-off-by: Benjamin Li <benli@broadcom.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Also applied, thanks.
next prev parent reply other threads:[~2008-09-18 23:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080918063933.GA8027@verge.net.au>
2008-09-18 16:57 ` [UPDATED][NET-NEXT PATCH 0/4] Minor bnx2 patches Benjamin Li
2008-09-18 16:57 ` [UPDATED][NET-NEXT PATCH 1/4] bnx2: In bnx2_set_mac_link() return void rather then int Benjamin Li
2008-09-18 16:57 ` [UPDATED][NET-NEXT PATCH 2/4] bnx2: Update MODULE_DESCRIPTION to include the 5716 Benjamin Li
2008-09-18 16:57 ` [UPDATED][NET-NEXT PATCH 3/4] bnx2: Remove name field from bnx2 structure Benjamin Li
2008-09-18 16:57 ` [UPDATED][NET-NEXT PATCH 4/4] bnx2: Remove timer_interval field from the " Benjamin Li
2008-09-18 23:40 ` David Miller [this message]
2008-09-18 23:40 ` [UPDATED][NET-NEXT PATCH 3/4] bnx2: Remove name field from " David Miller
2008-09-18 22:29 ` [UPDATED][NET-NEXT PATCH 2/4] bnx2: Update MODULE_DESCRIPTION to include the 5716 David Miller
2008-09-18 23:39 ` David Miller
2008-09-18 23:38 ` [UPDATED][NET-NEXT PATCH 1/4] bnx2: In bnx2_set_mac_link() return void rather then int David Miller
2008-09-18 17:04 ` [UPDATED][NET-NEXT PATCH 0/4] Minor bnx2 patches Jeff Garzik
2008-09-18 22:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080918.164058.43305872.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=benli@broadcom.com \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).