netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@infradead.org>
To: "Andy Fleming" <afleming@gmail.com>
Cc: "Matthew Wilcox" <matthew@wil.cx>,
	"David Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org
Subject: Re: multiqueue interrupts...
Date: Fri, 19 Sep 2008 15:28:44 -0700	[thread overview]
Message-ID: <20080919152844.4e5e26b5@infradead.org> (raw)
In-Reply-To: <2acbd3e40809191524w346a66abp230f334009840ba7@mail.gmail.com>

On Fri, 19 Sep 2008 17:24:00 -0500
"Andy Fleming" <afleming@gmail.com> wrote:

> On Fri, Sep 19, 2008 at 5:11 PM, Arjan van de Ven
> <arjan@infradead.org> wrote:
> > On Fri, 19 Sep 2008 12:18:41 -0600
> > Matthew Wilcox <matthew@wil.cx> wrote:
> 
> >> In a storage / NUMA configuration we really want to set up one
> >> queue per cpu / package / node (depending on resource constraints)
> >> and know that the interrupt is going to come back to the same
> >> cpu / package / node. We definitely don't want irqbalanced moving
> >> the interrupt around.
> >
> > irqbalance is NUMA aware and places a penalty on placing an
> > interrupt "wrongly". We can argue on how strong this penalty should
> > be, but thinking that irqbalance doesn't use the numa info the
> > kernel exposes is incorrect.
> >
> 
> I'm only just now wading into this area, but I thought one of the
> advantages of multiple hardware queues was that we don't have to worry
> about multiple cpus trying to access the buffer rings at the same
> time, thus eliminating locking.  If the driver can't rely on that,
> don't we lose that advantage?

that's only true if you have at least the amount of queues as you have
logical cpus. Ask SGI about how many cpus they have in 3 years, and
then ask your NIC vendor how many queues they have planned for ;-)

and a per-cpu lock isn't really all THAT expensive.
the really big advantage is that you no longer cacheline bounce to hell
and back... and that you have either way.


-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org

      reply	other threads:[~2008-09-19 22:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-19  2:38 multiqueue interrupts David Miller
2008-09-19 11:38 ` Ben Hutchings
2008-09-19 12:29   ` Brice Goglin
2008-09-19 20:12     ` David Miller
2008-09-19 20:12   ` David Miller
     [not found] ` <41b516cb0809191050t6c9783dele8926f697854bb1@mail.gmail.com>
2008-09-19 18:18   ` Matthew Wilcox
2008-09-19 20:14     ` David Miller
2008-09-19 20:57     ` Brandeburg, Jesse
2008-09-19 21:09       ` David Miller
2008-09-19 21:15         ` Matthew Wilcox
2008-09-19 22:11     ` Arjan van de Ven
2008-09-19 22:24       ` Andy Fleming
2008-09-19 22:28         ` Arjan van de Ven [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080919152844.4e5e26b5@infradead.org \
    --to=arjan@infradead.org \
    --cc=afleming@gmail.com \
    --cc=davem@davemloft.net \
    --cc=matthew@wil.cx \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).