From: David Miller <davem@davemloft.net>
To: akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
jens.axboe@oracle.com, steffen.klassert@secunet.com
Subject: Re: [PATCH 2/2]: softirq: Add support for triggering softirq work on softirqs.
Date: Sat, 20 Sep 2008 03:35:45 -0700 (PDT) [thread overview]
Message-ID: <20080920.033545.171821293.davem@davemloft.net> (raw)
In-Reply-To: <20080920004608.a3123052.akpm@linux-foundation.org>
From: Andrew Morton <akpm@linux-foundation.org>
Date: Sat, 20 Sep 2008 00:46:08 -0700
> Seems from the above `>> 16' you're stuffing the softirq ID into the
> upper 16 bits of call_single_data.flags. Is it needed? Another u32
> can be added to call_single_data for free on 64-bit, or it could be
> split into two u16's.
call_single_data is already too large, simply adding it to
struct sk_buff had negative performance impacts that are
forcing me to trim the size of the existing structure a bit.
I think just documenting the usage of the bits is better, and
I'll do that in my next rev.
next prev parent reply other threads:[~2008-09-20 10:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-20 6:48 [PATCH 2/2]: softirq: Add support for triggering softirq work on softirqs David Miller
2008-09-20 7:46 ` Andrew Morton
2008-09-20 10:35 ` David Miller [this message]
2008-09-20 10:56 ` David Miller
2008-09-20 17:42 ` Andrew Morton
2008-09-20 15:43 ` Daniel Walker
2008-09-20 20:03 ` David Miller
2008-09-20 20:16 ` Daniel Walker
2008-09-20 20:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080920.033545.171821293.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).