From: David Miller <davem@davemloft.net>
To: alexander.h.duyck@intel.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] netdev: simple_tx_hash shouldn't hash inside fragments
Date: Sat, 20 Sep 2008 22:06:24 -0700 (PDT) [thread overview]
Message-ID: <20080920.220624.177591478.davem@davemloft.net> (raw)
In-Reply-To: <20080919004337.10035.3409.stgit@localhost.localdomain>
From: Alexander Duyck <alexander.h.duyck@intel.com>
Date: Thu, 18 Sep 2008 17:43:37 -0700
> Currently simple_tx_hash is hashing inside of udp fragments. As a result
> packets are getting getting sent to all queues when they shouldn't be.
> This causes a serious performance regression which can be seen by sending
> UDP frames larger than mtu on multiqueue devices. This change will make
> it so that fragments are hashed only as IP datagrams w/o any protocol
> information.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
As we discussed on IRC this fixes a pretty serious performance regression
compared to previous releases, so I added this to net-2.6 and will push
to Linus.
Thanks!
prev parent reply other threads:[~2008-09-21 5:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-19 0:43 [PATCH] netdev: simple_tx_hash shouldn't hash inside fragments Alexander Duyck
2008-09-21 5:06 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080920.220624.177591478.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.h.duyck@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).