From: Ralf Baechle <ralf@linux-mips.org>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: macro@linux-mips.org, u1@terran.org, linux-mips@linux-mips.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] MIPS checksum fix
Date: Sat, 20 Sep 2008 17:09:14 +0200 [thread overview]
Message-ID: <20080920150914.GA7725@linux-mips.org> (raw)
In-Reply-To: <20080919.230952.128619158.anemo@mba.ocn.ne.jp>
On Fri, Sep 19, 2008 at 11:09:52PM +0900, Atsushi Nemoto wrote:
> I think it would be better splitting bugfix and optimization. This
> code is too complex to do many things at a time, isn't it?
>
> > @@ -53,12 +53,14 @@
> > #define UNIT(unit) ((unit)*NBYTES)
> >
> > #define ADDC(sum,reg) \
> > - .set push; \
> > - .set noat; \
> > ADD sum, reg; \
> > sltu v1, sum, reg; \
> > ADD sum, v1; \
> > - .set pop
>
> Is this required? Just a cleanup?
It papers over potencially important warnings so had to go. I argue the
caller of ADDC should set noat mode, if at all.
Ralf
next prev parent reply other threads:[~2008-09-20 15:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.55.0809171104290.17103@cliff.in.clinika.pl>
[not found] ` <20080917.222350.41199051.anemo@mba.ocn.ne.jp>
[not found] ` <Pine.LNX.4.55.0809171501450.17103@cliff.in.clinika.pl>
[not found] ` <20080918.002705.78730226.anemo@mba.ocn.ne.jp>
[not found] ` <Pine.LNX.4.55.0809171917580.17103@cliff.in.clinika.pl>
[not found] ` <20080918220734.GA19222@linux-mips.org>
[not found] ` <Pine.LNX.4.55.0809190112090.22686@cliff.in.clinika.pl>
[not found] ` <20080919112304.GB13440@linux-mips.org>
2008-09-19 11:47 ` [PATCH] MIPS checksum fix Ralf Baechle
2008-09-19 12:07 ` Ralf Baechle
2008-09-19 12:15 ` Maciej W. Rozycki
2008-09-19 14:09 ` Atsushi Nemoto
2008-09-19 15:02 ` Maciej W. Rozycki
2008-09-20 15:09 ` Ralf Baechle [this message]
2008-09-23 21:52 ` Bryan Phillippe
2008-09-23 22:06 ` Ralf Baechle
2008-09-29 15:28 ` Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080920150914.GA7725@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
--cc=netdev@vger.kernel.org \
--cc=u1@terran.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).