From: Christoph Hellwig <hch@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Christoph Hellwig <hch@infradead.org>,
kkeil@suse.de, netdev@vger.kernel.org, andi@firstfloor.org,
ak@linux.intel.com
Subject: Re: [patch 4/4] mISDN: misc timerdev fixes
Date: Tue, 23 Sep 2008 07:45:34 -0400 [thread overview]
Message-ID: <20080923114530.GA568@infradead.org> (raw)
In-Reply-To: <20080923043005.358e19e7.akpm@linux-foundation.org>
On Tue, Sep 23, 2008 at 04:30:05AM -0700, Andrew Morton wrote:
> so.. this?
Much better.
> --- a/drivers/isdn/mISDN/timerdev.c~misdn-misc-timerdev-fixes-fix
> +++ a/drivers/isdn/mISDN/timerdev.c
> @@ -61,7 +61,7 @@ mISDN_open(struct inode *ino, struct fil
> init_waitqueue_head(&dev->wait);
> filep->private_data = dev;
> __module_get(THIS_MODULE);
> - return 0;
> + return nonseekable_open(ino, filep);
But this also shows that mISDN is kinda stuck in a different century.
Doing __module_get(THIS_MODULE) at the end of ->open is utterly racy,
it really needs to set a owner field in file_operations and rip this
cruft out.
Btw, can anyone explain WTF this timerdev module is doing? It's not
using any functionality from the rest of mISDN, it's not exporting
any functionality to it either but just provides a really awkward way
to expose dumb timers to userspace. What does it provide that the
normal timer syscalls can't provide?
next prev parent reply other threads:[~2008-09-23 11:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-22 21:51 [patch 4/4] mISDN: misc timerdev fixes akpm
2008-09-23 2:18 ` David Miller
2008-09-23 2:27 ` Andi Kleen
2008-09-23 6:34 ` Karsten Keil
2008-09-23 11:49 ` Christoph Hellwig
2008-09-23 10:40 ` Christoph Hellwig
2008-09-23 11:30 ` Andrew Morton
2008-09-23 11:45 ` Christoph Hellwig [this message]
2008-09-23 12:00 ` Karsten Keil
2008-09-23 17:31 ` Andrew Morton
2008-09-23 14:14 ` Andi Kleen
2008-09-23 14:17 ` [patch 4/4] mISDN: misc timerdev fixes II Andi Kleen
2008-09-23 15:58 ` Christoph Hellwig
2008-09-23 16:46 ` Andi Kleen
2008-09-23 16:48 ` Christoph Hellwig
2008-10-12 11:05 ` [patch 4/4] mISDN: misc timerdev fixes Christoph Hellwig
2008-10-13 2:11 ` Andrew Morton
2008-10-13 2:16 ` Christoph Hellwig
2008-10-13 4:00 ` David Miller
2008-10-13 11:56 ` Andrew Morton
2008-10-13 18:47 ` David Miller
2008-09-23 14:13 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080923114530.GA568@infradead.org \
--to=hch@infradead.org \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=kkeil@suse.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).