From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 7/9] [ETH]: Start net device with carrier down Date: Wed, 24 Sep 2008 15:24:57 -0700 (PDT) Message-ID: <20080924.152457.13104395.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, afleming@freescale.com To: tpiepho@freescale.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:35067 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751084AbYIXWZK (ORCPT ); Wed, 24 Sep 2008 18:25:10 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Trent Piepho Date: Wed, 24 Sep 2008 14:20:55 -0700 > The problem is that when the device is first created and opened, the state > bit indicating the carrier is down isn't set, i.e. the state is wrong. > When the carrier comes up for the first time no netlink event is sent, > since the device state indicated the carrier was already up. It works properly if the device driver does as it is supposed to, which is invoke netif_carrier_off() in it's ->open() method in this situation. Please fix the drivers where this is not happening.