From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 7/9] [ETH]: Start net device with carrier down Date: Wed, 24 Sep 2008 14:32:03 -0700 Message-ID: <20080924143203.1eba6bbe@extreme> References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Trent Piepho , Andy Fleming To: Trent Piepho Return-path: Received: from mail.vyatta.com ([76.74.103.46]:45739 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751517AbYIXVcH (ORCPT ); Wed, 24 Sep 2008 17:32:07 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 24 Sep 2008 14:20:55 -0700 Trent Piepho wrote: > Because it _is_ down when the device starts. > > The device's carrier status is controlled via the functions > netif_carrier_on() and netif_carrier_off(). These set or clear a bit > indicating the lower level link aka carrier is down, and if the state > changed, they fire off a routing netlink event. > > The problem is that when the device is first created and opened, the state > bit indicating the carrier is down isn't set, i.e. the state is wrong. > When the carrier comes up for the first time no netlink event is sent, > since the device state indicated the carrier was already up. > > Signed-off-by: Trent Piepho > CC: Andy Fleming > --- > net/ethernet/eth.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c > index a80839b..cdba6d0 100644 > --- a/net/ethernet/eth.c > +++ b/net/ethernet/eth.c > @@ -333,6 +333,7 @@ void ether_setup(struct net_device *dev) > dev->addr_len = ETH_ALEN; > dev->tx_queue_len = 1000; /* Ethernet wants good queues */ > dev->flags = IFF_BROADCAST|IFF_MULTICAST; > + dev->state = 1 << __LINK_STATE_NOCARRIER; > > memset(dev->broadcast, 0xFF, ETH_ALEN); > This breaks devices that never call netif_carrier_on. Standard practice is to call netif_carrier_off after allocation but before register_netdev