* Re: [PATCH] convert sbmac tx to spin_lock_irqsave to prevent early IRQ enable [not found] ` <20080917114051.GA30734@shell.devel.redhat.com> @ 2008-09-20 20:18 ` Ralf Baechle 2008-09-25 19:33 ` Jeff Garzik 0 siblings, 1 reply; 3+ messages in thread From: Ralf Baechle @ 2008-09-20 20:18 UTC (permalink / raw) To: Jeff Garzik; +Cc: Weiwei Wang, linux-mips, netdev On Wed, Sep 17, 2008 at 07:40:51AM -0400, Jeff Garzik wrote: > On Wed, Sep 17, 2008 at 10:25:37AM +0800, Weiwei Wang wrote: > > Netpoll will call the interrupt handler with interrupts > > disabled when using kgdboe, so spin_lock_irqsave() should > > be used instead of spin_lock_irq() to prevent interrupts > > from being incorrectly enabled. > > > > Signed-off-by: Weiwei Wang <weiwei.wang@windriver.com> > > --- > > drivers/net/sb1250-mac.c | 12 +++++++----- > > 1 files changed, 7 insertions(+), 5 deletions(-) > > Please send to jeff@garzik.org or jgarzik@pobox.com. Jeff - I haven't looked at kgdboe but if he's right half of drivers/net will need to be fixed ... Ralf ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] convert sbmac tx to spin_lock_irqsave to prevent early IRQ enable 2008-09-20 20:18 ` [PATCH] convert sbmac tx to spin_lock_irqsave to prevent early IRQ enable Ralf Baechle @ 2008-09-25 19:33 ` Jeff Garzik 2008-09-25 23:49 ` Ralf Baechle 0 siblings, 1 reply; 3+ messages in thread From: Jeff Garzik @ 2008-09-25 19:33 UTC (permalink / raw) To: Ralf Baechle; +Cc: Jeff Garzik, Weiwei Wang, linux-mips, netdev Ralf Baechle wrote: > On Wed, Sep 17, 2008 at 07:40:51AM -0400, Jeff Garzik wrote: > >> On Wed, Sep 17, 2008 at 10:25:37AM +0800, Weiwei Wang wrote: >>> Netpoll will call the interrupt handler with interrupts >>> disabled when using kgdboe, so spin_lock_irqsave() should >>> be used instead of spin_lock_irq() to prevent interrupts >>> from being incorrectly enabled. >>> >>> Signed-off-by: Weiwei Wang <weiwei.wang@windriver.com> >>> --- >>> drivers/net/sb1250-mac.c | 12 +++++++----- >>> 1 files changed, 7 insertions(+), 5 deletions(-) >> Please send to jeff@garzik.org or jgarzik@pobox.com. > > Jeff - I haven't looked at kgdboe but if he's right half of drivers/net > will need to be fixed ... Oh indeed. I mainly do it on a case-by-case basis where people care. I overall think its a bogus change that deserves pushback, but that involves non-networking layers. In the end, case-by-case application seemed to win. Jeff ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] convert sbmac tx to spin_lock_irqsave to prevent early IRQ enable 2008-09-25 19:33 ` Jeff Garzik @ 2008-09-25 23:49 ` Ralf Baechle 0 siblings, 0 replies; 3+ messages in thread From: Ralf Baechle @ 2008-09-25 23:49 UTC (permalink / raw) To: Jeff Garzik; +Cc: Jeff Garzik, Weiwei Wang, linux-mips, netdev On Thu, Sep 25, 2008 at 03:33:40PM -0400, Jeff Garzik wrote: >>> On Wed, Sep 17, 2008 at 10:25:37AM +0800, Weiwei Wang wrote: >>>> Netpoll will call the interrupt handler with interrupts >>>> disabled when using kgdboe, so spin_lock_irqsave() should >>>> be used instead of spin_lock_irq() to prevent interrupts >>>> from being incorrectly enabled. >>>> >>>> Signed-off-by: Weiwei Wang <weiwei.wang@windriver.com> >>>> --- >>>> drivers/net/sb1250-mac.c | 12 +++++++----- >>>> 1 files changed, 7 insertions(+), 5 deletions(-) >>> Please send to jeff@garzik.org or jgarzik@pobox.com. >> >> Jeff - I haven't looked at kgdboe but if he's right half of drivers/net >> will need to be fixed ... > > Oh indeed. I mainly do it on a case-by-case basis where people care. I > overall think its a bogus change that deserves pushback, but that > involves non-networking layers. In the end, case-by-case application > seemed to win. Turns out kgdboe isn't upstream yet - but netconsole apparently hast the same issue. Ralf ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-09-25 23:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <6781da3918e3c34d23e5f7e9cf777ab463a17d5e.1221613284.git.weiwei.wang@windriver.com>
[not found] ` <20080917114051.GA30734@shell.devel.redhat.com>
2008-09-20 20:18 ` [PATCH] convert sbmac tx to spin_lock_irqsave to prevent early IRQ enable Ralf Baechle
2008-09-25 19:33 ` Jeff Garzik
2008-09-25 23:49 ` Ralf Baechle
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).