From: Jarek Poplawski <jarkao2@gmail.com>
To: Corey Minyard <minyard@acm.org>
Cc: paulmck@linux.vnet.ibm.com,
Linux Kernel <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org, shemminger@vyatta.com
Subject: Re: [PATCH 1/1] Use RCU for the UDP hash lock
Date: Fri, 26 Sep 2008 21:50:24 +0200 [thread overview]
Message-ID: <20080926195024.GA2548@ami.dom.local> (raw)
In-Reply-To: <48DCE874.8070704@acm.org>
On Fri, Sep 26, 2008 at 08:49:40AM -0500, Corey Minyard wrote:
...
> I don't believe udp_disconnect() releases the socket.
> sk_common_release() seems to be the place where the refcount is
> decremented. But wherever it is done, it would have to be after the
> unhash.
...Which, BTW, could be repeated then, so hlist_del_init() matters
yet. (Another sign of such possibility should be this "if ()" in
udp_lib_unhash().)
Jarek P.
next prev parent reply other threads:[~2008-09-26 19:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-26 3:18 [PATCH 1/1] Use RCU for the UDP hash lock Corey Minyard
2008-09-26 4:09 ` Paul E. McKenney
2008-09-26 13:49 ` Corey Minyard
2008-09-26 19:50 ` Jarek Poplawski [this message]
2008-09-26 5:46 ` Jarek Poplawski
2008-09-26 13:37 ` Corey Minyard
[not found] <48DB2925.2070908@poczta.onet.pl>
2008-09-24 17:28 ` Corey Minyard
2008-09-24 19:40 ` Stephen Hemminger
2008-09-24 20:46 ` Corey Minyard
2008-09-25 15:29 ` Paul E. McKenney
2008-09-25 15:34 ` Stephen Hemminger
2008-09-25 19:21 ` Corey Minyard
2008-09-25 20:34 ` Stephen Hemminger
2008-09-25 8:45 ` Jarek Poplawski
2008-09-25 19:14 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080926195024.GA2548@ami.dom.local \
--to=jarkao2@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).