From: Vitaliy Gusev <vgusev@openvz.org>
To: David Miller <davem@davemloft.net>
Cc: den@openvz.org, xemul@openvz.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-2.6] ip: NULL pointer dereferrence in tcp_v(4|6)_send_ack
Date: Wed, 1 Oct 2008 13:06:15 +0400 [thread overview]
Message-ID: <200810011306.15745.vgusev@openvz.org> (raw)
In-Reply-To: <20081001.015246.92774687.davem@davemloft.net>
On 1 October 2008 12:52:46 David Miller wrote:
> From: "Denis V. Lunev" <den@openvz.org>
> Date: Tue, 30 Sep 2008 20:29:11 +0400
>
> > The following actions are possible:
> > tcp_v4_rcv
> > skb->dev = NULL;
> > tcp_v4_do_rcv
> > tcp_v4_hnd_req
> > tcp_check_req
> > req->rsk_ops->send_ack == tcp_v4_send_ack
> >
> > So, skb->dev can be NULL in tcp_v4_send_ack. We must obtain namespace
> > from dst entry. IPv6 codepath is similar.
> >
> > Thanks to Vitaliy Gusev <vgusev@openvz.org> for initial oops decoding.
> >
> > Signed-off-by: Denis V. Lunev <den@openvz.org>
>
> Vitaliy sent the same patch first, so I applied his copy :-)
Den's patch is not the same. My patch didn't fix IPv6 code.
>
> Thanks everyone.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Thank,
Vitaliy Gusev
next prev parent reply other threads:[~2008-10-01 8:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-30 16:13 [PATCH] Fix NULL dereference in tcp_4_send_ack() Vitaliy Gusev
2008-09-30 16:29 ` [PATCH net-2.6] ip: NULL pointer dereferrence in tcp_v(4|6)_send_ack Denis V. Lunev
2008-10-01 8:52 ` David Miller
2008-10-01 9:06 ` Vitaliy Gusev [this message]
2008-10-01 9:03 ` David Miller
2008-10-01 9:11 ` [PATCH net-2.6] ipv6: NULL pointer dereferrence in tcp_v6_send_ack Denis V. Lunev
2008-10-01 9:13 ` David Miller
2008-10-01 13:34 ` Arnaldo Carvalho de Melo
2008-10-01 13:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810011306.15745.vgusev@openvz.org \
--to=vgusev@openvz.org \
--cc=davem@davemloft.net \
--cc=den@openvz.org \
--cc=netdev@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).