From: Andrew Morton <akpm@linux-foundation.org>
To: Divy Le Ray <divy@chelsio.com>
Cc: jeff@garzik.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, swise@opengridcomputing.com
Subject: Re: [PATCH 2.6.28 1/1] cxgb3 - fix race in EEH
Date: Thu, 2 Oct 2008 18:00:11 -0700 [thread overview]
Message-ID: <20081002180011.16254a4e.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080926000528.11959.63712.stgit@speedy5>
On Thu, 25 Sep 2008 17:05:28 -0700
Divy Le Ray <divy@chelsio.com> wrote:
> A SGE queue set timer might access registers while in EEH recovery,
> triggering an EEH error loop. Stop all timers early in EEH process.
<looks>
It's deeply weird that t3_reset_qset() does
memset(&q->tx_reclaim_timer, 0, sizeof(q->tx_reclaim_timer));
There are lots of things in the timer_list which the driver has no
business modifying. For example, this might break the metadata in
Thomas's debugobjects stuff, which attempts to catch things being done
in the wrong order (I don't think it will, but still...).
Rerunning init_timer() should repair the damage, but I suspect a simple
q->tx_reclaim_timer.function = NULL; /* explanation goes here */
would suffice here.
t3_sge_alloc_qset() could use the newer setup_timer().
next prev parent reply other threads:[~2008-10-03 1:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-26 0:05 [PATCH 2.6.28 1/1] cxgb3 - fix race in EEH Divy Le Ray
2008-10-03 1:00 ` Andrew Morton [this message]
2008-10-09 0:41 ` Divy Le Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081002180011.16254a4e.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=divy@chelsio.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).