From: Stephen Hemminger <shemminger@vyatta.com>
To: Lennert Buytenhek <buytenh@wantstofly.org>
Cc: netdev@vger.kernel.org, Byron Bradley <byron.bbradley@gmail.com>,
Jesper Dangaard Brouer <jdb@comx.dk>,
Tim Ellis <tim.ellis@mac.com>,
Andy Fleming <afleming@freescale.com>,
Imre Kaloz <kaloz@openwrt.org>, Nicolas Pitre <nico@cam.org>,
Dirk Teurlings <dirk@upexia.nl>,
Peter van Valderen <p.v.valderen@gmail.com>
Subject: Re: [PATCH 3/6] [NET] dsa: add support for original DSA tagging format
Date: Fri, 3 Oct 2008 19:36:01 +0200 [thread overview]
Message-ID: <20081003193601.4f7fbe42@speedy> (raw)
In-Reply-To: <20080929023829.GI21560@xi.wantstofly.org>
Please use stronger types..
> +static inline int netdev_uses_dsa_tags(struct net_device *dev)
I would use:
static inline bool netdev_uses_dsa_tags(const struct net_device *dev)
> +int dsa_uses_dsa_tags(void *dsa_ptr);
extern bool dsa_uses_dsa_tags(const struct dsa_switch *dsa);
next prev parent reply other threads:[~2008-10-03 17:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-29 2:38 [PATCH 3/6] [NET] dsa: add support for original DSA tagging format Lennert Buytenhek
2008-10-03 17:25 ` Ben Hutchings
2008-10-03 19:32 ` Lennert Buytenhek
2008-10-04 11:22 ` Ben Hutchings
2008-10-05 23:56 ` Lennert Buytenhek
2008-10-03 17:36 ` Stephen Hemminger [this message]
2008-10-03 19:47 ` Lennert Buytenhek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081003193601.4f7fbe42@speedy \
--to=shemminger@vyatta.com \
--cc=afleming@freescale.com \
--cc=buytenh@wantstofly.org \
--cc=byron.bbradley@gmail.com \
--cc=dirk@upexia.nl \
--cc=jdb@comx.dk \
--cc=kaloz@openwrt.org \
--cc=netdev@vger.kernel.org \
--cc=nico@cam.org \
--cc=p.v.valderen@gmail.com \
--cc=tim.ellis@mac.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).