From: David Miller <davem@davemloft.net>
To: jarkao2@gmail.com
Cc: jcliburn@gmail.com, netdev@vger.kernel.org, jacliburn@bellsouth.net
Subject: Re: [PATCH] pkt_sched: Simplify dev_requeue_skb and dequeue_skb
Date: Mon, 06 Oct 2008 10:41:16 -0700 (PDT) [thread overview]
Message-ID: <20081006.104116.41099393.davem@davemloft.net> (raw)
In-Reply-To: <20081006173842.GA2610@ami.dom.local>
From: Jarek Poplawski <jarkao2@gmail.com>
Date: Mon, 6 Oct 2008 19:38:42 +0200
> pkt_sched: Simplify dev_requeue_skb and dequeue_skb
>
> qdisc->requeue was planned to universally replace all requeuing code,
> but at the top level we never requeue more than one skb, so qdisc->
> gso_skb is enough for this. qdisc->requeue would be used on the lower
> levels only for one level deep requeuing (like in sch_hfsc) after
> finishing all the changes.
>
> Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
I'll apply this, thanks.
prev parent reply other threads:[~2008-10-06 17:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-05 18:24 [net-next-2.6] Null pointer dereference in dev_gso_skb_destructor() Jay Cliburn
2008-10-06 9:45 ` [PATCH] " Jarek Poplawski
2008-10-06 16:55 ` David Miller
2008-10-06 17:38 ` [PATCH] pkt_sched: Simplify dev_requeue_skb and dequeue_skb Jarek Poplawski
2008-10-06 17:41 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081006.104116.41099393.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jacliburn@bellsouth.net \
--cc=jarkao2@gmail.com \
--cc=jcliburn@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).