From: David Miller <davem@davemloft.net>
To: ilpo.jarvinen@helsinki.fi
Cc: netdev@vger.kernel.org
Subject: Re: [PATCHv3 net-next] tcp: kill pointless urg_mode
Date: Tue, 07 Oct 2008 14:42:48 -0700 (PDT) [thread overview]
Message-ID: <20081007.144248.48552653.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0810041505340.697@wrl-59.cs.helsinki.fi>
From: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Sat, 4 Oct 2008 15:08:19 +0300 (EEST)
> On Sat, 4 Oct 2008, Ilpo Järvinen wrote:
>
> > On Fri, 3 Oct 2008, Ilpo Järvinen wrote:
> >
> > > On Fri, 3 Oct 2008, Ilpo Järvinen wrote:
> > >
> > > > It all started from me noticing that this urgent check in
> > > > tcp_clean_rtx_queue is unnecessarily inside the loop. Then
> > > > I took a longer look to it and found out that the users of
> > > > urg_mode can trivially do without. Just drag snd_up with
> > > > us when we advance.
> > >
> > > Please hold a minute with this one while I inspect why I saw
> > > some strange urg now in a tcpdump.
> >
> > Ok, now it's right with win probes too...
> >
> > --
> >
> > [PATCHv2 net-next] tcp: kill pointless urg_mode
>
> Even better this time... tcp_urg_mode moved to tcp_output.c and exchanged
> the tcp_transmit_skb checks to the original order.
>
> --
> [PATCHv3 net-next] tcp: kill pointless urg_mode
Oops, I'll apply this one instead, of course :)
next prev parent reply other threads:[~2008-10-07 21:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-02 21:55 [PATCH net-next] tcp: kill pointless urg_mode Ilpo Järvinen
2008-10-03 20:32 ` Ilpo Järvinen
2008-10-03 22:54 ` Ilpo Järvinen
2008-10-04 12:08 ` [PATCHv3 " Ilpo Järvinen
2008-10-07 21:42 ` David Miller [this message]
2008-10-07 21:42 ` [PATCH " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081007.144248.48552653.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).