From: David Miller <davem@davemloft.net>
To: roszenrami@gmail.com
Cc: dlstevens@us.ibm.com, netdev@vger.kernel.org,
netdev-owner@vger.kernel.org, pekkas@netcore.fi
Subject: Re: [PATCH 0/2] Multicast: add mc_count to in_device and to inet6_dev
Date: Tue, 07 Oct 2008 15:36:43 -0700 (PDT) [thread overview]
Message-ID: <20081007.153643.247018258.davem@davemloft.net> (raw)
In-Reply-To: <b25312890810012224h68a2444dob746eaf0ce80b111@mail.gmail.com>
From: "Rami Rosen" <roszenrami@gmail.com>
Date: Thu, 2 Oct 2008 08:24:33 +0300
> - When sending the patch, I was aware that the mc_count is currently
> not used (printed) in IPv6;
> I added it for the sake of symmetry with IPv4 and for future use.
Unused struct members take up space in every instance of that
datastructure, so we don't add things like this until we have
real uses.
> - Adding printing of mc_count in IPv6 is of course trivial; it was not
> added not because of laziness; I know less about IPv6 user space
> tools (which read "/proc/net/igmp6") ; I was afraid that adding
> printing of this mc_count field in IPv6 might break parsing of IPv6
> user space tools (like netstat, etc).
> So maybe this addition should be left for somebody who knows more
> about IPv6 user space tools ?
Of course modifying the output of this procfs file will break
things. This is yet another reason to not add the ipv6 side
mc_count until we actually come up with a real use.
prev parent reply other threads:[~2008-10-07 22:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-01 6:57 [PATCH 0/2] Multicast: add mc_count to in_device and to inet6_dev Rami Rosen
2008-10-01 9:08 ` David Miller
2008-10-02 5:24 ` Rami Rosen
2008-10-07 22:36 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081007.153643.247018258.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dlstevens@us.ibm.com \
--cc=netdev-owner@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pekkas@netcore.fi \
--cc=roszenrami@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).