From: David Miller <davem@davemloft.net>
To: dlstevens@us.ibm.com
Cc: den@openvz.org, benjamin.thery@bull.net, dlezcano@fr.ibm.com,
netdev@vger.kernel.org, netdev-owner@vger.kernel.org,
xemul@openvz.org, yoshfuji@linux-ipv6.org
Subject: Re: [PATCH net-next 10/14] ipv6: ICMP6MSGIN_INC_STATS is not used
Date: Wed, 08 Oct 2008 11:23:36 -0700 (PDT) [thread overview]
Message-ID: <20081008.112336.78710325.davem@davemloft.net> (raw)
In-Reply-To: <OFA8E1BB63.D89C2A10-ON882574DC.00607E02-882574DC.0060CF64@us.ibm.com>
From: David Stevens <dlstevens@us.ibm.com>
Date: Wed, 8 Oct 2008 10:37:25 -0700
> This is there to parallel the definitions for other stats
> macros. I don't think it should be removed, since it's
> part of the standard interface for incrementing counters.
> If someone has a need to increment it without, say, _BH,
> I wouldn't want them to have to come up with it from
> scratch again...
>
> It's cost is the two lines of code it takes, but you could
> consider it "documentation" for any future users that
> want that variant.
I disagree.
It's more work to change interfaces globally like these namespace
guys frequently have to, if we leave unused interfaces around.
The changelog history clearly contains the old macro so it can
be resurrected properly, and folks such as you or myself can
point this out if someone adds an improper reimplementation.
next prev parent reply other threads:[~2008-10-08 18:24 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-08 11:51 [PATCH net-next 0/14] ipv6: making IP/ICMP mibs per/namespace Denis V. Lunev
2008-10-08 11:51 ` [PATCH net-next 01/14] ipv6: local dev is actually unused in ip6_fragment Denis V. Lunev
2008-10-08 18:09 ` David Miller
2008-10-08 11:51 ` [PATCH net-next 02/14] ipv6: consolidate error paths in ipv6_frag_rcv Denis V. Lunev
2008-10-08 18:09 ` David Miller
2008-10-08 11:51 ` [PATCH net-next 03/14] netns: add net parameter to IP6_INC_STATS Denis V. Lunev
2008-10-08 18:09 ` David Miller
2008-10-08 11:51 ` [PATCH net-next 04/14] ipv6: added net argument to IP6_INC_STATS_BH Denis V. Lunev
2008-10-08 18:13 ` David Miller
2008-10-08 19:07 ` Denis V. Lunev
2008-10-08 11:51 ` [PATCH net-next 05/14] ipv6: added net argument to IP6_ADD_STATS_BH Denis V. Lunev
2008-10-08 18:13 ` David Miller
2008-10-08 11:51 ` [PATCH net-next 06/14] ipv6: added net argument to ICMP6_INC_STATS Denis V. Lunev
2008-10-08 18:14 ` David Miller
2008-10-08 11:51 ` [PATCH net-next 07/14] ipv6: added net argument to ICMP6_INC_STATS_BH Denis V. Lunev
2008-10-08 18:14 ` David Miller
2008-10-08 11:51 ` [PATCH net-next 08/14] ipv6: added net argument to ICMP6MSGOUT_INC_STATS Denis V. Lunev
2008-10-08 18:14 ` David Miller
2008-10-08 11:51 ` [PATCH net-next 09/14] ipv6: added net argument to ICMP6MSGOUT_INC_STATS_BH Denis V. Lunev
2008-10-08 18:15 ` David Miller
2008-10-08 11:51 ` [PATCH net-next 10/14] ipv6: ICMP6MSGIN_INC_STATS is not used Denis V. Lunev
2008-10-08 17:37 ` David Stevens
2008-10-08 18:23 ` David Miller [this message]
2008-10-08 18:15 ` David Miller
2008-10-08 11:51 ` [PATCH net-next 11/14] ipv6: added net argument to ICMP6MSGIN_INC_STATS_BH Denis V. Lunev
2008-10-08 18:16 ` David Miller
2008-10-08 11:52 ` [PATCH net-next 12/14] ipv6: added net argument to _DEVINC/_DEVADD Denis V. Lunev
2008-10-08 18:16 ` David Miller
2008-10-08 11:52 ` [PATCH net-next 13/14] ipv6: making ip and icmp statistics per/namespace Denis V. Lunev
2008-10-08 18:16 ` David Miller
2008-10-08 11:52 ` [PATCH net-next 14/14] ipv6: remove unused not init_ipv6_mibs/cleanup_ipv6_mibs Denis V. Lunev
2008-10-08 18:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081008.112336.78710325.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=benjamin.thery@bull.net \
--cc=den@openvz.org \
--cc=dlezcano@fr.ibm.com \
--cc=dlstevens@us.ibm.com \
--cc=netdev-owner@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xemul@openvz.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).