netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: romieu@fr.zoreil.com
Cc: ivecera@redhat.com, ilpo.jarvinen@helsinki.fi, netdev@vger.kernel.org
Subject: Re: r8169: read MAC address from EEPROM on init
Date: Thu, 09 Oct 2008 14:28:07 -0700 (PDT)	[thread overview]
Message-ID: <20081009.142807.229045310.davem@davemloft.net> (raw)
In-Reply-To: <20081009201607.GA20030@electric-eye.fr.zoreil.com>

From: Francois Romieu <romieu@fr.zoreil.com>
Date: Thu, 9 Oct 2008 22:16:07 +0200

> David Miller <davem@davemloft.net> :
> > 
> > Applied to net-next-2.6
> 
> rtl8169_init_one
> -> rtl_init_mac_address
>    -> rtl_rar_set
>       -> spin_lock_irq(&tp->lock);
> [...]
> -> spin_lock_init(&tp->lock);

Grrr...

> I am used to respin my patch kit anyway.

Please send it to me, I'd _REALLY_ appreciate this as the
only patches in the queue were posted by other people and
you're only mention or r8169 changes is you posting a pointer
to some GIT tree or patch set without any "dave/jeff please
pull this".

I'd rather you send me fixes as soon as you have them rather
than have them get clogged up in your tree for weeks or longer.
That's how mistakes like this happen.

If I don't have any fixes from the official person (you) then
I'm going to apply fixes that look OK from people who do actually
post them individually to the list for review.

:-)

  reply	other threads:[~2008-10-09 21:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-08 22:41 r8169: read MAC address from EEPROM on init David Miller
2008-10-09 20:16 ` Francois Romieu
2008-10-09 21:28   ` David Miller [this message]
2008-10-09 21:35     ` [PATCH] r8169: fix early spinlock use Francois Romieu
2008-10-09 21:36       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081009.142807.229045310.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=ilpo.jarvinen@helsinki.fi \
    --cc=ivecera@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).