From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: jeff@garzik.org, netdev@vger.kernel.org, david.graham@intel.com,
jesse.brandeburg@intel.com
Subject: Re: [NET-NEXT PATCH 1/2] e1000e: don't generate bad checksums for tcp packets with 0 csum
Date: Thu, 09 Oct 2008 14:29:36 -0700 (PDT) [thread overview]
Message-ID: <20081009.142936.00354103.davem@davemloft.net> (raw)
In-Reply-To: <20081009165831.32435.81922.stgit@gitlost.lost>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Thu, 09 Oct 2008 09:58:31 -0700
> When offloading transmit checksums only, the driver was not
> correctly configuring the hardware to handle the case of a zero
> checksum. For UDP the correct behavior is to leave it alone, but
> for tcp the checksum must be changed from 0x0000 to 0xFFFF. The
> hardware takes care of this case but only if it is told the
> packet is tcp.
>
> Signed-off-by: Dave Graham <david.graham@intel.com>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
prev parent reply other threads:[~2008-10-09 21:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-09 16:58 [NET-NEXT PATCH 1/2] e1000e: don't generate bad checksums for tcp packets with 0 csum Jeff Kirsher
2008-10-09 16:58 ` [NET-NEXT PATCH 2/2] e1000: " Jeff Kirsher
2008-10-09 21:29 ` David Miller
2008-10-09 21:29 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081009.142936.00354103.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=david.graham@intel.com \
--cc=jeff@garzik.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).