From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [NET-NEXT PATCH 2/2] e1000: don't generate bad checksums for tcp packets with 0 csum Date: Thu, 09 Oct 2008 14:29:45 -0700 (PDT) Message-ID: <20081009.142945.135108546.davem@davemloft.net> References: <20081009165831.32435.81922.stgit@gitlost.lost> <20081009165852.32435.79524.stgit@gitlost.lost> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: jeff@garzik.org, netdev@vger.kernel.org, david.graham@intel.com, jesse.brandeburg@intel.com To: jeffrey.t.kirsher@intel.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:42129 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1755772AbYJIVaK (ORCPT ); Thu, 9 Oct 2008 17:30:10 -0400 In-Reply-To: <20081009165852.32435.79524.stgit@gitlost.lost> Sender: netdev-owner@vger.kernel.org List-ID: From: Jeff Kirsher Date: Thu, 09 Oct 2008 09:58:52 -0700 > When offloading transmit checksums only, the driver was not > correctly configuring the hardware to handle the case of a zero > checksum. For UDP the correct behavior is to leave it alone, but > for tcp the checksum must be changed from 0x0000 to 0xFFFF. The > hardware takes care of this case but only if it is told the > packet is tcp. > > same patch as e1000e > > Signed-off-by: Dave Graham > Signed-off-by: Jesse Brandeburg > Signed-off-by: Jeff Kirsher Applied.