From: David Miller <davem@davemloft.net>
To: acme@redhat.com
Cc: ilpo.jarvinen@helsinki.fi, yoshfuji@linux-ipv6.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 2/4] tcpv6: trivial formatting changes to send_(ack|reset)
Date: Thu, 09 Oct 2008 14:38:59 -0700 (PDT) [thread overview]
Message-ID: <20081009.143859.113768989.davem@davemloft.net> (raw)
In-Reply-To: <20081009141658.GB24905@ghostprotocols.net>
From: Arnaldo Carvalho de Melo <acme@redhat.com>
Date: Thu, 9 Oct 2008 11:16:58 -0300
> Em Thu, Oct 09, 2008 at 12:58:07PM +0300, Ilpo Järvinen escreveu:
> > On Thu, 9 Oct 2008, YOSHIFUJI Hideaki / ???? wrote:
> > > I usually prefer sizeof(var) (or sizeof(*ptr)) over sizeof(type).
> > > Could you justify this change?
> >
> > My point was to make those two functions as equal as possible before merge
> > so that it's more easier to track what happens at the merge, both
> > versions pre-existed anyway. Sure I don't have much opinion either way.
>
> I agree with Yoshifuji, albeit it is unlikely that the type of that
> variable will change 8)
I agree as well and therefore left out the first hunk of this
patch when adding it to net-next-2.6
next prev parent reply other threads:[~2008-10-09 21:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-09 9:35 [PATCH 1/4] tcpv[46]: fix md5 pseudoheader address field ordering Ilpo Järvinen
2008-10-09 9:35 ` [PATCH 2/4] tcpv6: trivial formatting changes to send_(ack|reset) Ilpo Järvinen
2008-10-09 9:35 ` [PATCH 3/4] tcpv6: convert opt[] -> topt in tcp_v6_send_reset Ilpo Järvinen
2008-10-09 9:35 ` [PATCH 4/4] tcpv6: combine tcp_v6_send_(reset|ack) Ilpo Järvinen
2008-10-09 21:42 ` David Miller
2008-10-09 21:42 ` [PATCH 3/4] tcpv6: convert opt[] -> topt in tcp_v6_send_reset David Miller
2008-10-09 9:52 ` [PATCH 2/4] tcpv6: trivial formatting changes to send_(ack|reset) YOSHIFUJI Hideaki / 吉藤英明
2008-10-09 9:58 ` Ilpo Järvinen
2008-10-09 14:16 ` Arnaldo Carvalho de Melo
2008-10-09 21:38 ` David Miller [this message]
2008-10-09 21:40 ` David Miller
2008-10-10 12:00 ` Ilpo Järvinen
2008-10-09 21:37 ` [PATCH 1/4] tcpv[46]: fix md5 pseudoheader address field ordering David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081009.143859.113768989.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=acme@redhat.com \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).