From: David Miller <davem@davemloft.net>
To: berni@birkenwald.de
Cc: netdev@vger.kernel.org, herbert@gondor.apana.org.au
Subject: Re: WARNING (skb_gso_segment) with tg3+bridge in 2.6.27
Date: Mon, 13 Oct 2008 00:42:26 -0700 (PDT) [thread overview]
Message-ID: <20081013.004226.171259546.davem@davemloft.net> (raw)
In-Reply-To: <20081011172002.GA12659@pest>
From: Bernhard Schmidt <berni@birkenwald.de>
Date: Sat, 11 Oct 2008 19:20:03 +0200
> [ 289.588669] ------------[ cut here ]------------
> [ 289.588673] WARNING: at net/core/dev.c:1505 skb_gso_segment+0x82/0x1a7()
>
> if (WARN_ON(skb->ip_summed != CHECKSUM_PARTIAL)) {
So this is via tg3_tso_bug()
...
> [ 289.588760] [<ffffffff803d14ab>] dev_queue_xmit+0x3aa/0x462
> [ 289.588778] [<ffffffffa024ca8c>] ip6_output+0xce7/0xcff [ipv6]
> [ 289.588785] [<ffffffffa023ade0>] br_dev_queue_push_xmit+0x75/0x79 [bridge]
> [ 289.588792] [<ffffffffa023a2fe>] br_dev_xmit+0x66/0x7c [bridge]
> [ 289.588795] [<ffffffff803d1535>] dev_queue_xmit+0x434/0x462
> [ 289.588811] [<ffffffffa024ca8c>] ip6_output+0xce7/0xcff [ipv6]
> [ 289.588827] [<ffffffffa024b8b4>] ip6_xmit+0x35c/0x439 [ipv6]
> [ 289.588848] [<ffffffffa026d303>] inet6_csk_xmit+0x223/0x236 [ipv6]
> [ 289.588850] [<ffffffff80443e8e>] _spin_lock_irqsave+0x21/0x29
> [ 289.588853] [<ffffffff804059ff>] tcp_transmit_skb+0x60f/0x64e
And it seems we have a TCP TSO frame that went through bridging
netfilter.
Herbert, is there something about checksum state changing done
by bridging netfilter that we have to be mindful of in
skb_gso_segment() and therefore not consider "!= CHECKSUM_PARTIAL"
a warn-worthy case?
next prev parent reply other threads:[~2008-10-13 7:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-11 17:20 WARNING (skb_gso_segment) with tg3+bridge in 2.6.27 Bernhard Schmidt
2008-10-13 7:42 ` David Miller [this message]
2008-10-13 7:59 ` Herbert Xu
2008-10-22 7:45 ` Herbert Xu
2008-10-22 17:57 ` Matt Carlson
2008-10-23 2:20 ` Herbert Xu
2008-10-23 17:13 ` Michael Chan
2008-10-24 14:33 ` Herbert Xu
2009-05-07 21:23 ` Ferenc Wágner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081013.004226.171259546.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=berni@birkenwald.de \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).