From: David Miller <davem@davemloft.net>
To: acme@redhat.com
Cc: ilpo.jarvinen@helsinki.fi, netdev@vger.kernel.org
Subject: Re: [PATCH] pktgen: fix skb leak in case of failure
Date: Mon, 13 Oct 2008 18:45:49 -0700 (PDT) [thread overview]
Message-ID: <20081013.184549.251334267.davem@davemloft.net> (raw)
In-Reply-To: <20081013170158.GA10494@ghostprotocols.net>
From: Arnaldo Carvalho de Melo <acme@redhat.com>
Date: Mon, 13 Oct 2008 14:01:58 -0300
> Em Mon, Oct 13, 2008 at 05:22:18PM +0300, Ilpo Järvinen escreveu:
> > Seems that skb goes into void unless something magic happened
> > in pskb_expand_head in case of failure.
> >
> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
>
> Good catch!
>
> Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Applied, thanks everyone.
prev parent reply other threads:[~2008-10-14 1:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-13 14:22 [PATCH] pktgen: fix skb leak in case of failure Ilpo Järvinen
2008-10-13 17:01 ` Arnaldo Carvalho de Melo
2008-10-14 1:45 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081013.184549.251334267.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=acme@redhat.com \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).