From: Ben Dooks <ben-linux@fluff.org>
To: Jeff Garzik <jeff@garzik.org>
Cc: Ben Dooks <ben-linux@fluff.org>, netdev <netdev@vger.kernel.org>
Subject: Re: [patch 1/2] drivers/net/bonding: sparse fixes for exported tables
Date: Mon, 13 Oct 2008 10:23:47 +0100 [thread overview]
Message-ID: <20081013092347.GA11059@fluff.org.uk> (raw)
In-Reply-To: <48DAF424.2060808@garzik.org>
On Wed, Sep 24, 2008 at 10:15:00PM -0400, Jeff Garzik wrote:
> Ben Dooks wrote:
>> The following sparse warnings are being generated
>> because bonding.h is missing definitons for items
>> declared in bond_main.c but also used in bond_sysfs.h
>>
>> Also export bond_dev_list as this is also declared
>> in bond_main but used elsewhere in drivers/net/bonding.
>>
>> bond_main.c:105:20: warning: symbol 'bonding_defaults' was not declared. Should it be static?
>> bond_main.c:148:1: warning: symbol 'bond_dev_list' was not declared. Should it be static?
>> bond_main.c:162:22: warning: symbol 'bond_lacp_tbl' was not declared. Should it be static?
>> bond_main.c:168:22: warning: symbol 'bond_mode_tbl' was not declared. Should it be static?
>> bond_main.c:179:22: warning: symbol 'xmit_hashtype_tbl' was not declared. Should it be static?
>> bond_main.c:186:22: warning: symbol 'arp_validate_tbl' was not declared. Should it be static?
>> bond_main.c:194:22: warning: symbol 'fail_over_mac_tbl' was not declared. Should it be static?
>>
>> Signed-off-by: Ben Dooks <ben-linux@fluff.org>
>>
>> Index: linux-git-test-next-cats/drivers/net/bonding/bonding.h
>> ===================================================================
>> --- linux-git-test-next-cats.orig/drivers/net/bonding/bonding.h 2008-09-14 16:39:30.000000000 +0100
>> +++ linux-git-test-next-cats/drivers/net/bonding/bonding.h 2008-09-14 16:44:24.000000000 +0100
>> @@ -333,5 +333,13 @@ void bond_change_active_slave(struct bon
>> void bond_register_arp(struct bonding *);
>> void bond_unregister_arp(struct bonding *);
>> +/* exported from bond_main.c */
>> +extern struct list_head bond_dev_list;
>> +extern struct bond_parm_tbl bond_lacp_tbl[];
>> +extern struct bond_parm_tbl bond_mode_tbl[];
>> +extern struct bond_parm_tbl xmit_hashtype_tbl[];
>> +extern struct bond_parm_tbl arp_validate_tbl[];
>> +extern struct bond_parm_tbl fail_over_mac_tbl[];
>
> applied
>
> patch #2 failed to apply
ok, will sort this out and send a new patch.
--
Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
next prev parent reply other threads:[~2008-10-13 9:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-14 15:56 [patch 0/2] drivers/net/bonding sparse errors Ben Dooks
2008-09-14 15:56 ` [patch 1/2] drivers/net/bonding: sparse fixes for exported tables Ben Dooks
2008-09-25 2:15 ` Jeff Garzik
2008-10-13 9:23 ` Ben Dooks [this message]
2008-09-14 15:56 ` [patch 2/2] drivers/net/bonding: move mutex decleration to header Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081013092347.GA11059@fluff.org.uk \
--to=ben-linux@fluff.org \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).