From: Martin Langer <martin-langer@gmx.de>
To: netdev@vger.kernel.org
Subject: [PATCH] de2104x: wrong MAC address fix
Date: Mon, 13 Oct 2008 20:04:59 +0200 [thread overview]
Message-ID: <20081013180459.GA3389@tuba> (raw)
The de2104x returns sometimes a wrong MAC address. The wrong one is
like the original one, but it comes with an one byte shift. I found
this bug on an older alpha ev5 cpu. More details are available in Gentoo
bugreport #240718.
It seems the hardware is sometimes a little bit too slow for an
immediate access. This patch solves the problem by introducing a small
udelay.
Signed-off-by: Martin Langer <martin-langer@gmx.de>
--- drivers/net/tulip/de2104x.c_ORIGINAL 2008-10-10 00:13:53.000000000 +0200
+++ drivers/net/tulip/de2104x.c 2008-10-11 19:04:32.000000000 +0200
@@ -1689,6 +1689,7 @@
unsigned i;
dw32 (ROMCmd, 0); /* Reset the pointer with a dummy write. */
+ udelay(5);
for (i = 0; i < 6; i++) {
int value, boguscnt = 100000;
next reply other threads:[~2008-10-13 18:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-13 18:04 Martin Langer [this message]
2008-10-14 1:49 ` [PATCH] de2104x: wrong MAC address fix David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081013180459.GA3389@tuba \
--to=martin-langer@gmx.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).