* [PATCH] de2104x: wrong MAC address fix
@ 2008-10-13 18:04 Martin Langer
2008-10-14 1:49 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Martin Langer @ 2008-10-13 18:04 UTC (permalink / raw)
To: netdev
The de2104x returns sometimes a wrong MAC address. The wrong one is
like the original one, but it comes with an one byte shift. I found
this bug on an older alpha ev5 cpu. More details are available in Gentoo
bugreport #240718.
It seems the hardware is sometimes a little bit too slow for an
immediate access. This patch solves the problem by introducing a small
udelay.
Signed-off-by: Martin Langer <martin-langer@gmx.de>
--- drivers/net/tulip/de2104x.c_ORIGINAL 2008-10-10 00:13:53.000000000 +0200
+++ drivers/net/tulip/de2104x.c 2008-10-11 19:04:32.000000000 +0200
@@ -1689,6 +1689,7 @@
unsigned i;
dw32 (ROMCmd, 0); /* Reset the pointer with a dummy write. */
+ udelay(5);
for (i = 0; i < 6; i++) {
int value, boguscnt = 100000;
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] de2104x: wrong MAC address fix
2008-10-13 18:04 [PATCH] de2104x: wrong MAC address fix Martin Langer
@ 2008-10-14 1:49 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-10-14 1:49 UTC (permalink / raw)
To: martin-langer; +Cc: netdev
From: Martin Langer <martin-langer@gmx.de>
Date: Mon, 13 Oct 2008 20:04:59 +0200
> The de2104x returns sometimes a wrong MAC address. The wrong one is
> like the original one, but it comes with an one byte shift. I found
> this bug on an older alpha ev5 cpu. More details are available in Gentoo
> bugreport #240718.
>
> It seems the hardware is sometimes a little bit too slow for an
> immediate access. This patch solves the problem by introducing a small
> udelay.
>
> Signed-off-by: Martin Langer <martin-langer@gmx.de>
Looks good, applied, thanks Martin.
> --- drivers/net/tulip/de2104x.c_ORIGINAL 2008-10-10 00:13:53.000000000 +0200
> +++ drivers/net/tulip/de2104x.c 2008-10-11 19:04:32.000000000 +0200
> @@ -1689,6 +1689,7 @@
Please -p1 base your patches in the future.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-10-14 1:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-13 18:04 [PATCH] de2104x: wrong MAC address fix Martin Langer
2008-10-14 1:49 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).