From: Stephen Hemminger <shemminger@vyatta.com>
To: David Miller <davem@davemloft.net>, Jeff Garzik <jgarzik@pobox.com>
Cc: netdev@vger.kernel.org, linux-pci@vger.kernel.org
Subject: [PATCH 8/9] skge: add VPD display into debug interface
Date: Mon, 13 Oct 2008 13:13:10 -0700 [thread overview]
Message-ID: <20081013201453.344338423@vyatta.com> (raw)
In-Reply-To: 20081013201302.899587376@vyatta.com
[-- Attachment #1: skge-vpd-debug.patch --]
[-- Type: text/plain, Size: 2844 bytes --]
The VPD stuff has more data and useful only when debugging.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/drivers/net/skge.c 2008-10-13 13:04:10.000000000 -0700
+++ b/drivers/net/skge.c 2008-10-13 13:04:16.000000000 -0700
@@ -3670,19 +3670,102 @@ static int skge_reset(struct skge_hw *hw
static struct dentry *skge_debug;
+/*
+ * Read and parse the first part of Vital Product Data
+ */
+#define VPD_SIZE 128
+#define VPD_MAGIC 0x82
+
+static const struct vpd_tag {
+ char tag[2];
+ char *label;
+} vpd_tags[] = {
+ { "PN", "Part Number" },
+ { "EC", "Engineering Level" },
+ { "MN", "Manufacturer" },
+ { "SN", "Serial Number" },
+ { "YA", "Asset Tag" },
+ { "VL", "First Error Log Message" },
+ { "VF", "Second Error Log Message" },
+ { "VB", "Boot Agent ROM Configuration" },
+ { "VE", "EFI UNDI Configuration" },
+};
+
+static void skge_show_vpd(struct seq_file *seq, struct skge_hw *hw)
+{
+ size_t vpd_size;
+ loff_t offs;
+ u8 len;
+ unsigned char *buf;
+ u32 reg2;
+
+ pci_read_config_dword(hw->pdev, PCI_DEV_REG2, ®2);
+ vpd_size = 1 << ( ((reg2 & PCI_VPD_ROM_SZ) >> 14) + 8);
+
+ seq_printf(seq, "%s Product Data\n", pci_name(hw->pdev));
+ buf = kmalloc(vpd_size, GFP_KERNEL);
+ if (!buf) {
+ seq_puts(seq, "no memory!\n");
+ return;
+ }
+
+ if (pci_read_vpd(hw->pdev, 0, vpd_size, buf) < 0) {
+ seq_puts(seq, "VPD read failed\n");
+ goto out;
+ }
+
+ if (buf[0] != VPD_MAGIC) {
+ seq_printf(seq, "VPD tag mismatch: %#x\n", buf[0]);
+ goto out;
+ }
+ len = buf[1];
+ if (len == 0 || len > vpd_size - 4) {
+ seq_printf(seq, "Invalid id length: %d\n", len);
+ goto out;
+ }
+
+ seq_printf(seq, "%.*s\n", len, buf + 3);
+ offs = len + 3;
+
+ while (offs < vpd_size - 4) {
+ int i;
+
+ if (!memcmp("RW", buf + offs, 2)) /* end marker */
+ break;
+ len = buf[offs + 2];
+ if (offs + len + 3 >= vpd_size)
+ break;
+
+ for (i = 0; i < ARRAY_SIZE(vpd_tags); i++) {
+ if (!memcmp(vpd_tags[i].tag, buf + offs, 2)) {
+ seq_printf(seq, " %s: %.*s\n",
+ vpd_tags[i].label, len, buf + offs + 3);
+ break;
+ }
+ }
+ offs += len + 3;
+ }
+out:
+ kfree(buf);
+}
+
static int skge_debug_show(struct seq_file *seq, void *v)
{
struct net_device *dev = seq->private;
const struct skge_port *skge = netdev_priv(dev);
- const struct skge_hw *hw = skge->hw;
+ struct skge_hw *hw = skge->hw;
const struct skge_element *e;
- if (!netif_running(dev))
- return -ENETDOWN;
+ skge_show_vpd(seq, hw);
seq_printf(seq, "IRQ src=%x mask=%x\n", skge_read32(hw, B0_ISRC),
skge_read32(hw, B0_IMSK));
+ if (!netif_running(dev)) {
+ seq_printf(seq, "network not running\n");
+ return 0;
+ }
+
seq_printf(seq, "Tx Ring: (%d)\n", skge_avail(&skge->tx_ring));
for (e = skge->tx_ring.to_clean; e != skge->tx_ring.to_use; e = e->next) {
const struct skge_tx_desc *t = e->desc;
--
next prev parent reply other threads:[~2008-10-13 21:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-13 20:13 [PATCH 0/9] Vital Product Data (VPD) patches relating to skge/sky2 Stephen Hemminger
2008-10-13 20:13 ` [PATCH 1/9] PCI: vpd handle longer delays in access Stephen Hemminger
2008-10-13 20:13 ` [PATCH 2/9] PCI: revise VPD access interface Stephen Hemminger
2008-10-13 20:13 ` [PATCH 3/9] PCI: add interface to set visible size of VPD (rev3) Stephen Hemminger
2008-10-13 20:13 ` [PATCH 4/9] sky2: set VPD size Stephen Hemminger
2008-10-13 20:13 ` [PATCH 5/9] sky2: move VPD display into debug interface Stephen Hemminger
2008-10-13 20:13 ` [PATCH 6/9] sky2: remove eeprom interface Stephen Hemminger
2008-10-13 20:13 ` [PATCH 7/9] skge: set VPD size Stephen Hemminger
2008-10-13 20:13 ` Stephen Hemminger [this message]
2008-10-13 20:13 ` [PATCH 9/9] skge: remove ethtool eeprom interface Stephen Hemminger
-- strict thread matches above, loose matches on Subject: below --
2008-09-25 16:48 [PATCH 0/9] PCI vpd patches (rev4) Stephen Hemminger
2008-09-25 16:48 ` [PATCH 8/9] skge: add VPD display into debug interface Stephen Hemminger
2008-09-25 17:23 ` Jeff Garzik
2008-09-09 18:20 [PATCH 0/9] PCI VPD related patches Stephen Hemminger
2008-09-09 18:20 ` [PATCH 8/9] skge: add VPD display into debug interface Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081013201453.344338423@vyatta.com \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).