From: Stephen Hemminger <shemminger@vyatta.com>
To: Krzysztof Oledzki <ole@ans.pl>
Cc: Herbert Xu <herbert@gondor.apana.org.au>, netdev@vger.kernel.org
Subject: Re: Error: an inet prefix is expected rather than "0/0".
Date: Tue, 14 Oct 2008 12:18:55 -0700 [thread overview]
Message-ID: <20081014121855.2f931be0@extreme> (raw)
In-Reply-To: <alpine.LNX.1.10.0810142113140.7684@bizon.gios.gov.pl>
On Tue, 14 Oct 2008 21:15:18 +0200 (CEST)
Krzysztof Oledzki <ole@ans.pl> wrote:
>
>
> On Tue, 14 Oct 2008, Stephen Hemminger wrote:
>
> > On Tue, 14 Oct 2008 22:01:27 +0800
> > Herbert Xu <herbert@gondor.apana.org.au> wrote:
> >
> >> Krzysztof Oledzki <ole@ans.pl> wrote:
> >>>
> >>> http://git.kernel.org/?p=linux/kernel/git/shemminger/iproute2.git;a=commitdiff_plain;h=2ca4abdcb823e708b88156f947fa5b493055618a
> >>>
> >>> ;)
> >>
> >> Hmm, this breaks several scripts of mine that use 10/8. Couldn't
> >> we just fall back to the old loop when inet_aton fails?
> >>
> >> Thanks,
> >
> >
> > There is no easy solution, I'll will have to go back rewrite this
> > code, and will document the result. I expect the result will displease
> > someone, but given the original code that is just going to happen.
> >
> > Busted cases:
> > correct incorrect
> > Original code: 127.2 => 127.0.0.2 127.2.0.0
> > inet_pton: 10.0 => 10.0.0.0 fails invalid
> > inet_aton: 10 => 10.0.0.0 0.0.0.10
> >
> > The problem was Alexey (or Jamal) invented their own abbreviation format
> > and did not follow unix standard conventions.
>
> It seems that the original code followed the unix standard:
>
> # telnet 127.2
> Trying 127.0.0.2...
> telnet: connect to address 127.0.0.2: Connection refused
The incorrect column lists the actual result for each of the routines.
Original code converted 127.2 to 127.2.0.0
next prev parent reply other threads:[~2008-10-14 19:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-08 21:05 Error: an inet prefix is expected rather than "0/0" Krzysztof Oledzki
2008-10-08 21:32 ` Krzysztof Oledzki
2008-10-14 14:01 ` Herbert Xu
2008-10-14 17:46 ` Stephen Hemminger
2008-10-14 19:15 ` Krzysztof Oledzki
2008-10-14 19:18 ` Stephen Hemminger [this message]
2008-10-14 19:38 ` Ben Hutchings
2008-10-14 21:52 ` Patrick McHardy
2008-10-14 21:54 ` Patrick McHardy
2008-10-15 1:46 ` Herbert Xu
2008-10-15 15:35 ` Krzysztof Halasa
2008-10-15 16:07 ` Ben Hutchings
2008-10-15 18:52 ` Krzysztof Halasa
2008-10-27 17:39 ` Stephen Hemminger
2008-10-28 1:51 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081014121855.2f931be0@extreme \
--to=shemminger@vyatta.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=ole@ans.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).