From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: Error: an inet prefix is expected rather than "0/0". Date: Tue, 14 Oct 2008 12:18:55 -0700 Message-ID: <20081014121855.2f931be0@extreme> References: <20081014104621.3c2ce4d3@extreme> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Herbert Xu , netdev@vger.kernel.org To: Krzysztof Oledzki Return-path: Received: from mail.vyatta.com ([76.74.103.46]:57555 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751235AbYJNTTB (ORCPT ); Tue, 14 Oct 2008 15:19:01 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 14 Oct 2008 21:15:18 +0200 (CEST) Krzysztof Oledzki wrote: > > > On Tue, 14 Oct 2008, Stephen Hemminger wrote: > > > On Tue, 14 Oct 2008 22:01:27 +0800 > > Herbert Xu wrote: > > > >> Krzysztof Oledzki wrote: > >>> > >>> http://git.kernel.org/?p=linux/kernel/git/shemminger/iproute2.git;a=commitdiff_plain;h=2ca4abdcb823e708b88156f947fa5b493055618a > >>> > >>> ;) > >> > >> Hmm, this breaks several scripts of mine that use 10/8. Couldn't > >> we just fall back to the old loop when inet_aton fails? > >> > >> Thanks, > > > > > > There is no easy solution, I'll will have to go back rewrite this > > code, and will document the result. I expect the result will displease > > someone, but given the original code that is just going to happen. > > > > Busted cases: > > correct incorrect > > Original code: 127.2 => 127.0.0.2 127.2.0.0 > > inet_pton: 10.0 => 10.0.0.0 fails invalid > > inet_aton: 10 => 10.0.0.0 0.0.0.10 > > > > The problem was Alexey (or Jamal) invented their own abbreviation format > > and did not follow unix standard conventions. > > It seems that the original code followed the unix standard: > > # telnet 127.2 > Trying 127.0.0.2... > telnet: connect to address 127.0.0.2: Connection refused The incorrect column lists the actual result for each of the routines. Original code converted 127.2 to 127.2.0.0